[mythtv-commits] [MythTV/mythtv] b47e46: Playback Subtitle fixes

[Peter Bennett]

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: b47e464825b7acaadc2d21de76ce6cfbd181ed1c
      https://github.com/MythTV/mythtv/commit/b47e464825b7acaadc2d21de76ce6cfbd181ed1c
  Author: Peter Bennett <pbennett at mythtv.org>
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
    M mythtv/libs/libmythtv/captions/subtitlereader.cpp
    M mythtv/libs/libmythtv/captions/subtitlereader.h
    M mythtv/libs/libmythtv/captions/subtitlescreen.cpp
    M mythtv/libs/libmythtv/captions/textsubtitleparser.cpp
    M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp
    M mythtv/libs/libmythtv/mythplayercaptionsui.cpp

  Log Message:
  -----------
  Playback Subtitle fixes

Fix these problems
- External text subtitles displayed at the same time as internal subtitles.
- Selecting external subtitles from the menu not displaying any subtitles.
- Intermittent segmentation faults when enabling subtitles.
- External subtitles not appearing when switching from internal to external.

External text subtitles now being processed by FFmpeg are treated
as AV subtitles but still need to be identified as external text
subtitles.

- Add a flag to identify external subtitles to SubtitleReader.
- When internal subtitles are selected, discard external subtitles
- When external subtitles are selected, discard internal subtitles.
- Add checks to prevent segmentation faults on invalid frames.
- Set needsync. When switching from AV subtitles to external
  subtitles the subtitles were not showing.

Refs #773