[mythtv-commits] [MythTV/mythtv] 991d0f: Fix crash of goom visualisation in MythMusic
noreply at github.com
Wed Dec 22 19:49:02 UTC 2021
Author: Klaas de Waal <kdewaal at mythtv.org>
Date: 2021-12-22 (Wed, 22 Dec 2021)
Fix crash of goom visualisation in MythMusic
The value returned by iRAND is used as an array index in
visualisations/goom/tentacle3d.cpp at line 188:
float val = (float)(ShiftRight(data[iRAND(511)],10)) * rapport;
The problem is that iRAND can return negative values and this
is sufficient to cause the problems mentioned in issue #429.
Fixed by changing the iRAND function to return an unsigned integer value.
Note there is a commented-out implementation of iRAND present in the code;
this implementation does also return an unsigned integer value.
More information about the mythtv-commits