[mythtv-commits] [MythTV/mythtv] 70315c: Fix uninitialized memory access in goom visualiser

kmdewaal noreply at github.com
Wed Dec 22 19:32:20 UTC 2021

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: 70315c0a1dd3b7d99e70b63f15d114f4d81eaa5b
  Author: Klaas de Waal <kdewaal at mythtv.org>
  Date:   2021-12-22 (Wed, 22 Dec 2021)

  Changed paths:
    M mythtv/libs/libmythtv/visualisations/goom/goom_core.cpp

  Log Message:
  Fix uninitialized memory access in goom visualiser

The random number table with 65536 ((0x10000) elements was
initialized except for the first element.
The initialization code is changed to a for loop that does
initialize all elements of the table.
Note that the while loop in the original code was only
somewhat correct if the size of the table, given in NB_RAND, was
equal to the maximum value of a 16-bit unsigned integer plus one.

Refs #429

More information about the mythtv-commits mailing list