[mythtv-commits] Ticket #12974: Auto expire has race condition

MythTV noreply at mythtv.org
Thu Feb 2 19:09:15 UTC 2017

#12974: Auto expire has race condition
 Reporter:  amb@…                 |          Owner:
     Type:  Bug Report - General  |         Status:  new
 Priority:  minor                 |      Milestone:  29.0
Component:  MythTV - General      |        Version:  0.28.0
 Severity:  medium                |     Resolution:
 Keywords:                        |  Ticket locked:  0

Comment (by amb@…):

 The approach of re-scanning the list for pending deletes when mythbackend
 is started is certainly one way to do it and much better than my idea of a
 5 minute grace time.

 Removing the deletepending flag from the database altogether is a much
 better solution though.
 1. It simplifies things in general
 2. The rescanning at startup (above) is not needed because the list will
 be rescanned after a short time anyway and if there is no deletepending
 flag then it can't stop them being deleted.
 3. It is only a snapshot - a file in the Deleted recordings group that
 isn't pending for deletion right now might be pending for deletion in 1
 second's time so the list is obsolete as soon as it is created.
 4. The UI should already handle the case of files disappearing from
 recording groups (e.g. deleted from a different frontend) so listing a
 file even while it is being deleted and then having it disappear should be
 5. The frontend should already handle the case of files being deleted
 while being watched (e.g. deleted permanently from a different frontend)
 so having them listed and selectable for watching even when about to be
 deleted should be OK.

 I can't see anything wrong with removing deletepending completely that
 isn't already a bug of another type (points 3, 4 and 5 above).

Ticket URL: <https://code.mythtv.org/trac/ticket/12974#comment:3>
MythTV <http://www.mythtv.org>
MythTV Media Center

More information about the mythtv-commits mailing list