[mythtv-commits] mythtv branch fixes/0.25 updated by jyavenard. v0.25-36-g977b470

Git Repo Owner noreply at mythtv.org
Wed Apr 18 10:55:55 UTC 2012

The branch, fixes/0.25 has been updated on the
mythtv repository by gitolite user jyavenard.
       via  977b470172e2bd6d4f960fabaae92183e6b20c65 (commit)
      from  674e37ab7d16f5a8ee7c8426dcb7a594a23fa75f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 977b470172e2bd6d4f960fabaae92183e6b20c65
Author:    Jean-Yves Avenard <jyavenard at mythtv.org> at Wed, 18 Apr 2012 20:48:28 +1000
Committer: Jean-Yves Avenard <jyavenard at mythtv.org> at Wed, 18 Apr 2012 20:54:59 +1000
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=977b470172e2bd6d4f960fabaae92183e6b20c65

Fix possible undefined behaviours in libmythprotoserver
The intermediary QByteBuffer returned by toLocal8Bit would have been destroyed at the end of the expression, making the pointer used invalid.

Wondering what kind of crash/instability this would have caused.
I went through the whole code, and only found those two.

Thanks to Malcolm Parsons (pepsiman) for reporting a similar issue in 9ea5252bc3a6367dacec1b4f92f03c13fbd0f0e4.

[cherry-picked from 5aaca58157c6456b88e500ccacbde91e31dcb534]


Summary of changes:
 .../requesthandler/deletethread.cpp                |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)


More information about the mythtv-commits mailing list