[mythtv-commits] mythtv branch master updated by jyavenard. v0.26-pre-92-g5aaca58

Git Repo Owner noreply at mythtv.org
Wed Apr 18 10:52:24 UTC 2012

The branch, master has been updated on the
mythtv repository by gitolite user jyavenard.
       via  5aaca58157c6456b88e500ccacbde91e31dcb534 (commit)
      from  87b3f9cd7e6ec1ee7a3b8691652125d01c60e1b8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5aaca58157c6456b88e500ccacbde91e31dcb534
Author:    Jean-Yves Avenard <jyavenard at mythtv.org> at Wed, 18 Apr 2012 20:48:28 +1000
Committer: Jean-Yves Avenard <jyavenard at mythtv.org> at Wed, 18 Apr 2012 20:52:23 +1000
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=5aaca58157c6456b88e500ccacbde91e31dcb534

Fix possible undefined behaviours in libmythprotoserver
The intermediary QByteBuffer returned by toLocal8Bit would have been destroyed at the end of the expression, making the pointer used invalid.

Wondering what kind of crash/instability this would have caused.
I went through the whole code, and only found those two.

Thanks to Malcolm Parsons (pepsiman) for reporting a similar issue in 9ea5252bc3a6367dacec1b4f92f03c13fbd0f0e4.


Summary of changes:
 .../requesthandler/deletethread.cpp                |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)


More information about the mythtv-commits mailing list