[mythtv-commits] Ticket #9801: mythtranscode produces unusable output when transcoding mpeg4->mpeg4 with cutlists
MythTV
noreply at mythtv.org
Thu Nov 24 04:24:34 UTC 2011
#9801: mythtranscode produces unusable output when transcoding mpeg4->mpeg4 with
cutlists
------------------------------------+----------------------------
Reporter: mythtv@… | Owner:
Type: Bug Report - General | Status: closed
Priority: minor | Milestone: unknown
Component: MythTV - Mythtranscode | Version: 0.24-fixes
Severity: medium | Resolution: Duplicate
Keywords: mythtranscode cutlist | Ticket locked: 0
------------------------------------+----------------------------
Comment (by mythtv@…):
OK here is the fix and patch - it's trivial.... (the problem was due to
subtracting 1 from frame 0 which resulted in something like frame 2^32^ -
1 due to unsigned long long type of stuff).
This explains why it only happens in transcoding nuv (since the problem is
only in the nuppeldecoder). Also, by tracing through the code you can see
why it only takes affect when there is a cutlist.
Assuming you accept this patch, this bug can now be finally closed (note
that you might want to edit the ERRONEOUS marking of this bug as a
duplicate of bug #8864 since as I first noted 4 months ago this bug has
absolutely NOTHING to do with that other long outstanding mythtranscoding
bug).
{{{
--- nuppeldecoder.cpp.jorig 2011-10-28 10:53:21.000000000 -0400
+++ nuppeldecoder.cpp 2011-11-23 23:02:24.288482191 -0500
@@ -1124,7 +1124,7 @@
else if (frameheader.comptype == 'V')
{
lastKey = frameheader.timecode;
- framesPlayed = frameheader.timecode - 1;
+ framesPlayed = (frameheader.timecode > 0 ?
frameheader.timecode - 1 : 0);
if (!hasFullPositionMap)
{
}}}
--
Ticket URL: <http://code.mythtv.org/trac/ticket/9801#comment:16>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
More information about the mythtv-commits
mailing list