[mythtv-commits] mythtv commit: r19277 by danielk

mythtv at cvs.mythtv.org mythtv at cvs.mythtv.org
Mon Dec 8 00:12:19 UTC 2008


      Author: danielk
        Date: 2008-12-08 00:12:19 +0000 (Mon, 08 Dec 2008)
New Revision: 19277
   Changeset: http://cvs.mythtv.org/trac/changeset/19277

Modified:

   branches/mythtv-vid/libs/libmythtv/tv_play.cpp
   branches/mythtv-vid/libs/libmythtv/tv_play.h

Log:

Refs #2287. Don't try to restart LiveTV if we have hit an irrecoverable error in starting LiveTV.

Basically the reasoning is that if we hit an irrecoverable error once, we will likely hit it again and again on each retry.

This could easilly be extended to retry a few times before giving up, but I've only seen this occur with truly irrecoverable errors, such as the recording directory not being mounted. In trunk we set wantsToQuit to true for these irrecoverable errors, but that is not correct, since wantsToQuit indicates that the user wants to quit the app, and when there is an irrecoverable error we really want to show an error dialog then quit..

AFAIK: This problem really only occurs in practice because we haven't ported the error dialogs in the NVP and TV classes to Qt4 yet, but even once we do -- this change will prevent infinite loops if we forget to implement an error exit dialog for some irrecoverable eror.




More information about the mythtv-commits mailing list