[mythtv-commits] Ticket #4042: 0.20-fixes won't build on macines with DVB API < 3.1

[MythTV]

#4042: 0.20-fixes won't build on macines with DVB API < 3.1
-----------------------+----------------------------------------------------
 Reporter:  anonymous  |       Owner:  ijr       
     Type:  defect     |      Status:  new       
 Priority:  major      |   Milestone:  unknown   
Component:  mythtv     |     Version:  0.20-fixes
 Severity:  high       |     Mlocked:  0         
-----------------------+----------------------------------------------------
 The current revision of the 0.20-fixes branch has this code in
 [http://svn.mythtv.org/trac/browser/branches/release-0-20-fixes/mythtv/libs/libmythtv/frequencytables.cpp
 frequencytables.cpp], lines 78 and 82:
 {{{
 fe_type type = FE_QPSK;

 type = (_cardtype.upper() == "ATSC")   ? FE_ATSC   : type;
 }}}

 However, the same revision's
 [http://svn.mythtv.org/trac/browser/branches/release-0-20-fixes/mythtv/libs/libmythtv/dvbtypes.h
 dvbtypes.h] has this code: (Lines 39-44)
 {{{
 #if (DVB_API_VERSION >= 3 && DVB_API_VERSION_MINOR >= 1)
 #    define USE_ATSC
 #else
 #warning DVB API version < 3.1
 #warning ATSC will not be supported using the Linux DVB drivers
 #    define FE_ATSC       (FE_OFDM+1)
 }}}
 Thus, compiling the release on a system with a DVB API < 3.1 (in my case a
 Gentoo 2.6.10 with linuxdvb 1.1.1) resulted in a compilation error:
 {{{
 In file included from dvbchannel.h:22,
 from frequencytables.h:17,
 from frequencytables.cpp:1:
 dvbtypes.h:42:2: warning: #warning DVB API version < 3.1
 dvbtypes.h:43:2: warning: #warning ATSC will not be supported using
 the Linux DVB drivers
 frequencytables.cpp: In constructor
 `TransportScanItem::TransportScanItem(int,
 const QString&, const QString&, const QString&, const DTVTransport&,
 unsigned int)':
 frequencytables.cpp:82: error: invalid conversion from `int' to `fe_type'
 }}}

 [http://svn.mythtv.org/trac/changeset/11702/trunk/mythtv/libs/libmythtv/frequencytables.cpp
 Changeset 11702] removed the offending code from frequencytables.cpp,
 however I didn't test out whether I could get it to compile with the rest
 of 0.20-fixes on my system.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/4042>
MythTV <http://svn.mythtv.org/trac>
MythTV