[mythtv-commits] Ticket #1271: register commercial-skip and audio-sync-adjustment key bindings
MythTV
mythtv at cvs.mythtv.org
Mon Feb 13 04:34:34 UTC 2006
#1271: register commercial-skip and audio-sync-adjustment key bindings
-------------------------------------+--------------------------------------
Reporter: Robert Tsai <rtsai1111> | Owner: ijr
Type: patch | Status: new
Priority: trivial | Milestone:
Component: mythtv | Version: head
Severity: low |
-------------------------------------+--------------------------------------
TOGGLEAUDIOSYNC is not registered in the TV Playback key bindings; this
patch registers a key binding for it. I chose "Y" because I *think*
playing back recordings ought to be disjoint with live TV, but I might be
wrong, in which case a different default key should be used. I'm a little
confused here because some actions (e.g., SIGNALMON) verify the "in Live
TV" state before doing anything, while others that seem non-Live-TV-ish
don't similarly validate their state (QUEUETRANCODE, SPEEDINC, etc.).
This patch also adds a new CYCLECOMMSKIP action and registers a key
binding for it. I chose 'R' because I think LiveTV and Recorded TV
playback should be able to re-use keys without colliding with each other,
but maybe the "real-time" commercial flagging enables comm-skipping during
LiveTV, in which case something other than "R" should be chosen.
I also do a little bit of cleanup; the "commercialskipmethod" variable
appears to be unused ...
--
Ticket URL: <http://svn.mythtv.org/trac/ticket/1271>
MythTV <http://www.mythtv.org/>
MythTV
More information about the mythtv-commits
mailing list