[mythtv-users] Hey, there's a new Steppes v34.2 - ha, nope, fooled you.

[Paul Gardiner]

On 18/02/2025 15:38, David Hampton wrote:
> 
> Its a bug, and I'm surprised it took this long to surface.  The problem
> is that the backend service that periodically downloads themes chooses
> "trunk" if the source path (aka branch) doesn't start with "fixes/".
> The frontend, however, only chooses "trunk" if the source version
> contains "-pre".  My libmythbase/version.h file looks like this:
> 
>    static constexpr const char* MYTH_SOURCE_VERSION \
>       { "v34.0-38-gac34c663b2-dirty" };
>    static constexpr const char* MYTH_SOURCE_PATH \
>       { "fixes-34" };
> 
> So based on the above, the backend chooses "trunk" because "fixes-"
> doesn't match "fixes/", and the frontend chooses not trunk because
> there's no "-pre" in the version.
> 
> As an aside: in the "not trunk" case, both frontend and backend do the
> same thing and use a combination of MYTH_BINARY_VERSION and
> MYTH_SOURCE_VERSION to get the decide which version of the themes.zip
> file to retrieve.
> 
> I think this code should be cleaned up.  Using three different strings
> to figure out the right version of the themes file to retrieve doesn't
> make a lot of sense, nor does duplicating that code in two different
> places.  I think this decision could be consolidated into a single
> function and keyed off MYTH_SOURCE_VERSION.Oh

Oh, nice find. My version.h has

static constexpr const char* MYTH_SOURCE_VERSION
	{ "v34.0-32-gd309161e2b-dirty" };
static constexpr const char* MYTH_SOURCE_PATH
	{ "fix-forced-subtitles-failing-to-clear-fixes34" };

So, I guess as a work around I could rename my branch
fixes/34-xxxxxxxxxxxxxx