[mythtv-users] [mythtv-theming] Theme update via MythTV theme chooser

[Peter Bennett]

On 03/20/2017 07:45 AM, Stuart Auchterlonie wrote:
> On 12/03/17 19:36, Peter Bennett wrote:
>>
>> On 03/12/2017 01:35 PM, jaham at gmx.net wrote:
>>> Hi Peter...
>>>
>>> I am using the official ArchLinux packages. However mythfrontend
>>> version says:
>>> MythTV Version : 3543e74
>>> MythTV Branch : tag: v0.28
>>> Network Protocol : 88
>>> Library API : 0.28.20160309-1
>>> QT Version : 5.7.0
>>>
>>> So that might indeed be the reason as you suspected. If that is not a
>>> general
>>> problem for users, than I can live with that. I had the fear that the
>>> wrong
>>> version is advertised to users.
>>>
>>> Ciao Jan
>> Actually it needs both Branch and Version to be correct for the correct
>> theme to be downloaded. You should have something like this:
>>
>> MythTV Version : v0.28.1
>> MythTV Branch : fixes/0.28
>> Network Protocol : 88
>> Library API : 0.28.20161120-1
>> QT Version : 5.5.1
>>
>> If the version a later commit later than the tag you could see
>> MythTV Version : v0.28.1-95-g93c8cf8
>> MythTV Branch : fixes/0.28
>> ...
>>
>> Either of these is valid but with yours showing the version as 3543e74
>> the theme download will always use the trunk version of themes.
>>
>> You may want to take this up with the packager.
>>
> Well actually, if they are using the "tagged" 0.28 release (aka, the GA
> version) then this looks like a bug on our side.
>
> Interestingly enough, if we fixed it, then the version would move to
> fixes/0.28 and it would just work anyway.....
>
> Regards
> Stuart
>
>
Hi Stuart

I looked at the code a few weeks ago and if I understand it correctly, 
the branch has to start with "fixes", and if it does then the code 
parses the version number. In this user's case the branch starts with 
"tag" and the version number is a commit hash, so could not be parsed 
even if the fixes check was bypassed. I am not sure of the best way to 
fix it.

Peter