[mythtv-users] Mythlink, season & episode data, and specials - Patch

Stuart Auchterlonie stuarta at squashedfrog.net
Sun Feb 7 21:16:17 UTC 2016


On 04/02/16 17:42, Michael wrote:
> On 02/03/2016 01:23 PM, Michael wrote:
>> Hello,
>>
>> I am using mythlink with MythTV 0.27.5 on Fedora 23 x86_64 using
>> packages from rpmfusion.
>>
>> With the recent updates to mythlink, it has the ability to create
>> output including season and episode.  This is most useful if you also
>> consume mythtv content in xbmc, plex, etc.  It is a great addition.
>>
>> One gap that I have noticed though is the handling of special episodes.
>>
>> I usually use this format: "%T/%T - S%ssE%ep - %S" to give output
>> like: The X- Files/The X- Files - S10E01 - My Struggle.mpg
>>
>> if the season and episode data is non existent, which is represented
>> by 0 and 0 in the database, you get links like:
>>
>> The X- Files/The X- Files - SE - My Struggle.mpg which is ok, but not
>> great.
>>
>> However, in the case of special episodes, those are usually season 0,
>> but with an episode number: American Ninja Warrior/American Ninja
>> Warrior - SE03 - USA vs. the World.mpg
>>
>> You end up with plex trying to parse the name.  It seems to find the
>> episode and guessing season 1 for the season.
>>
>> I am hoping this is a simple patch to mythlink such that if the
>> episode is not zero, but the season is 0, then go ahead and print the
>> 0 season anyway.
>>
> 
> I dug into this further and the issue isn't actually in mythlink, but
> rather it is in Program.pm in the perl bindings.
> 
> This patch fixes the issue:
> 
> 
> --- Program.pm.good     2015-06-16 09:03:30.000000000 -0700
> +++ Program.pm  2016-02-04 10:25:56.497196500 -0700
> @@ -321,10 +321,11 @@
>          }
>      # Season/Episode/InetRef
>          my ($season, $episode, $inetref);
> -        $season = ($self->{'season'} or '');
> -        $season = "0$season" if ($season && $season < 10);
>          $episode = ($self->{'episode'} or '');
>          $episode = "0$episode" if ($episode && $episode < 10);
> +        $season = ($self->{'season'} or '');
> +        $season = "0$season" if ($season && $season < 10);
> +       $season = "00" if ($season eq '' && $episode ne '');
>          $inetref = ($self->{'inetref'} or '');
> 
>      # Build a list of name format options
> 
> 
> What is the process to get someone to look at this and/or commit it?
> 
> Michael
> 

Open a ticket in trac (https://code.mythtv.org/trac) describing the
problem with the patch included.

Please do your diff's in the form

$ diff -u old_file new_file


Regards
Stuart




More information about the mythtv-users mailing list