[mythtv-users] nVidia driver 304.88: problems

[Jean-Yves Avenard]

On 16 April 2013 17:52, Paul Gardiner <lists at glidos.net> wrote:

>
> I meant, rather than a change in the code, that the driver was causing
> GetVideoModes to return fresh objects (perhaps because GetVideoModes
> used a cache and the driver was returning constantly altering info
> that caused cache misses - something like that). In any case, I'm
> mistaken, but the fact remains that it does fix the problem, whatever
> the cause might be.
>

Nah.. did you actually have a look at the code?
Changing:
-    bool chg = !(next == m_last) ||  +    bool chg = !(next.Width()
== m_last.Width()) ||  +               !(next.Height() ==
m_last.Height()) ||
is totally useless

next and m_last are instances of DisplayResScreen. It overrides the ==
operator with:
inline bool DisplayResScreen::operator == (const DisplayResScreen &b) const
{
    return width == b.width && height == b.height;
}

The patch overall is very non-elegant, it brakes totally the MV approach,
changing the list of modes and overriding it.

The only thing that is actually doing something is that bit:
+    next.ClearRefreshRates();   +    next.AddRefreshRate(target_rate);
it pretty much discard everything done above and force only one refresh
rate to be used...

That's just not the way to do it.

Now if I could reproduce the issue you are seeing, I will definitely have a
shot at it... but the particular patch you're using is certainly not the
way to do it.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mythtv.org/pipermail/mythtv-users/attachments/20130416/56b32a7d/attachment.html>