[mythtv-users] [patch] VideoOutputXv: XVideo Adaptor Name: 'Intel(R) Textured Video' unsupported attribute
Marc MERLIN
marc_mtv at merlins.org
Wed Sep 24 17:39:42 UTC 2008
Howdy,
I think I found a small problem with the current code in videoout_xv.cpp
and intel G35 video. The code still picks the wrong visual (first one, see included
mail below why the first one is bad).
I'll be honest in not being too sure where to set "chromakey" in vdp.GetOSDRenderer()
(maybe in the DB somewhere), but is there a reason for that not to be default?
At least on that intel chip, picking a visual without XV_COLORKEY causes pretty
bad playback on the textured video port.
Also note that without my 'patch' (not a patch really), playback outputs this errors
on the default textured port:
> 2008-09-24 07:22:58.161 VideoOutputXv: @ j=0 Looking for flag[s]: XvInputMask XvImageMask 10
> 2008-09-24 07:22:58.161 VideoOutputXv: Adaptor#0: Intel(R) Textured Video has flag[s]: XvInputMask XvImageMask
> 2008-09-24 07:22:58.161 VideoOutputXv: Has XVideo flags...
> 2008-09-24 07:22:58.161 VideoOutputXv: Has XV_BRIGHTNESS...
> 2008-09-24 07:22:58.161 VideoOutputXv: Here...
> 2008-09-24 07:22:58.161 VideoOutputXv: Grabbed xv port 65
> 2008-09-24 07:22:58.162 VideoOutputXv: XVideo surface found on port 65
> 2008-09-24 07:22:58.162 VideoOutputXv: XVideo Adaptor Name: 'Intel(R) Textured Video'
> 2008-09-24 07:22:58.162 VideoOutputXv: XVideo Format #0 is 'YUY2'
> 2008-09-24 07:22:58.162 VideoOutputXv: XVideo Format #1 is 'YV12'
> 2008-09-24 07:22:58.162 VideoOutputXv: XVideo Format #2 is 'I420'
> 2008-09-24 07:22:58.162 VideoOutputXv: XVideo Format #3 is 'UYVY'
> 2008-09-24 07:22:58.162 VideoOutputXv: XVideo Format #4 is 'XVMC'
> 2008-09-24 07:22:58.163 VideoOutputXv: Using XVideo Format 'YV12'
> 2008-09-24 07:22:58.163 VideoOutputXv: CreateShmImages(32): video_dim: 1920x1088
> 2008-09-24 07:22:58.253 VDP: SetVideoRenderer(xv-blit)
> 2008-09-24 07:22:58.253 VDP: SetVideoRender(xv-blit) == GetVideoRenderer()
> 2008-09-24 07:22:58.253 VideoOutputXv: Chromakeying not possible with this XVideo port.
> 2008-09-24 07:22:58.253 VideoOutputXv: PictureAttributes: Brightness, Contrast
> 2008-09-24 07:22:58.256
>
>
> unsupported attribute
this ^^^^^^^^^^^^^^^^^^^^
--- ../mythtv-0.21.0+fixes18207/libs/libmythtv/videoout_xv.cpp 2008-04-02 10:52:17.000000000 -0700
+++ ./libs/libmythtv/videoout_xv.cpp 2008-09-24 10:31:10.000000000 -0700
@@ -653,8 +653,7 @@
vdp.SetInput(QSize(width, height));
bool check_for_colorkey = (vdp.GetOSDRenderer() == "chromakey");
- // if we want colorkey capability try to get an adapter with them
- if (check_for_colorkey)
+ if (true || check_for_colorkey)
{
uint end = req.size();
for (uint i = 0; i < end; i++)
Can someone who knows more about the common case than I do fix the default code
so that it picks the correct visual on the intel G35 boards?
Thanks,
Marc
----- Forwarded message from Marc MERLIN <marc_mtv at merlins.org> -----
From: Marc MERLIN <marc_mtv at merlins.org>
To: mythtv-users at mythtv.org
Subject: VideoOutputXv: XVideo Adaptor Name: 'Intel(R) Textured Video' unsupported attribute
X-Sysadmin: BOFH
X-URL: http://marc.merlins.org/
X-Operating-System: Proudly running Linux 2.6.24.3-p3smp-volpreempt-100hz-magic3/Debian woody
I just built a new myth system with an Asus P5E-VM HDMI G35.
I have mythtv 0.21.0+fixes16 and xserver-xorg-video-intel 2.4.1-1ubuntu4
mplayer -vo xv is slow and because it wrongly picks "Intel(R) Textured Video"
mplayer -vo xv:port=81 works fine however.
Googling shows that ./libs/libmythtv/videoout_xv.cpp should already be picking the
right port since it has a XV_COLORKEY check, but that does not seem to work for me:
2008-09-21 22:51:21.287 NVP: Disabling Audio, params(-1,2,44100)
2008-09-21 22:51:21.300 VideoOutputXv: XVideo Adaptor Name: 'Intel(R) Textured Video'
2008-09-21 22:51:21.323
unsupported attribute
2008-09-21 22:51:21.323
unsupported attribute
2008-09-21 22:51:21.325 OSD Theme Dimensions W: 640 H: 480
Any idea why it picks the wrong visual and what I can do to fix it?
Thanks,
Marc
X-Video Extension version 2.2
screen #0
Adaptor #0: "Intel(R) Textured Video"
number of ports: 16
port base: 65
operations supported: PutImage
supported visuals:
depth 24, visualID 0x21
number of attributes: 2
"XV_BRIGHTNESS" (range -128 to 127)
client settable attribute
client gettable attribute (current value is 0)
"XV_CONTRAST" (range 0 to 255)
client settable attribute
client gettable attribute (current value is 128)
maximum XvImage size: 1920 x 1088
(...)
Adaptor #1: "Intel(R) Video Overlay"
number of ports: 1
port base: 81
operations supported: PutImage
supported visuals:
depth 24, visualID 0x21
number of attributes: 12
"XV_COLORKEY" (range 0 to 16777215)
client settable attribute
client gettable attribute (current value is 66046)
"XV_BRIGHTNESS" (range -128 to 127)
client settable attribute
client gettable attribute (current value is -19)
"XV_CONTRAST" (range 0 to 255)
client settable attribute
client gettable attribute (current value is 75)
"XV_SATURATION" (range 0 to 1023)
client settable attribute
client gettable attribute (current value is 146)
"XV_DOUBLE_BUFFER" (range 0 to 1)
client settable attribute
client gettable attribute (current value is 1)
"XV_PIPE" (range -1 to 1)
client settable attribute
client gettable attribute (current value is -1)
"XV_GAMMA0" (range 0 to 16777215)
client settable attribute
client gettable attribute (current value is 526344)
"XV_GAMMA1" (range 0 to 16777215)
client settable attribute
client gettable attribute (current value is 1052688)
"XV_GAMMA2" (range 0 to 16777215)
client settable attribute
client gettable attribute (current value is 2105376)
"XV_GAMMA3" (range 0 to 16777215)
client settable attribute
client gettable attribute (current value is 4210752)
"XV_GAMMA4" (range 0 to 16777215)
client settable attribute
client gettable attribute (current value is 8421504)
"XV_GAMMA5" (range 0 to 16777215)
client settable attribute
client gettable attribute (current value is 12632256)
maximum XvImage size: 1920 x 1088
Number of image formats: 5
(...)
--
"A mouse is a device used to point at the xterm you want to type in" - A.S.R.
Microsoft is to operating systems & security ....
.... what McDonalds is to gourmet cooking
Home page: http://marc.merlins.org/
----- End forwarded message -----
--
"A mouse is a device used to point at the xterm you want to type in" - A.S.R.
Microsoft is to operating systems & security ....
.... what McDonalds is to gourmet cooking
Home page: http://marc.merlins.org/
----- End forwarded message -----
--
"A mouse is a device used to point at the xterm you want to type in" - A.S.R.
Microsoft is to operating systems & security ....
.... what McDonalds is to gourmet cooking
Home page: http://marc.merlins.org/
More information about the mythtv-users
mailing list