[PATCH] Re: [mythtv-users] How well does commercial detection work?

Risto Treksler risto at elkhornbanff.ca
Tue Apr 12 05:07:53 UTC 2005


Hi,

I haven't figured out why the minimum length is still not being honoured 
and so I am going to privately send you the full debug output
from a couple of such shows

NOTE:
I think it's OK to have commercials shorter than 60sec 
right in the beginning of the show!! 
these are detected fine all the time and should continue to be detected as is

however there shouldn't be any really short commercial sections 
in the middle of the show, but it's flagging them nonetheless
- (using method "all" with strict checking enabled)


ALSO here's a patch that fixes a few things

1) I DO NOT ignore logos in blank frames in STRICT mode

- this alone has eliminated virtually all false positives
- it even works reasonably well with shows that leave the logo up
  i end up having to watch the first or the last commercial, 
  but that's ok b/c there are no false positives.
  (There has got to be a way to: ONLY ignore these logos
   if there are no completely blank frames at all in the show)

2) fix for the messed up data in my previous post 

- long long vs. long
- "(long)it.key()"  probably would have done it as well
- it didn't like %7lld either

3) fix for "white frames" triggering false positives

- NOT ONLY  "(max - min) <= blankFrameMaxDiff"
- BUT ALSO "max < some reasonable amount"



On Monday 11 April 2005 04:07 pm, Chris Pinkham wrote:
> > downloaded todays CVS and reflagged
> > it detected and flagged an obviously false commercial of just 8 frames
> > long
> >
> > "white frames" like those in explosions and in scene transitions in Cold
> > Case also trigger false positives every time
>
> If you use the same instructions I gave the others earlier in this thread
> and email me (privately) the debug output, it might help me find and fix
> this.
>
> > 2005-04-11 14:31:23.170 Final Commercial Break Map
> > 2005-04-11 14:31:23.170
> > ---------------------------------------------------
> >
> > 2005-04-11 14:31:23.170 d : 7639 (00:04:00.04) (14)
> > 2005-04-11 14:31:23.171 d : 7646 (00:05:00.04) (14)
> > 2005-04-11 14:31:23.171 d : 102549 (00:04:00.56) (58)
> > 2005-04-11 14:31:23.171 d : 107739 (00:05:00.59) (51)
> > 2005-04-11 14:31:23.171
> > ---------------------------------------------------
>
> On second thought, something looks plain weird about this output anyway. 
> The output is all weird.  Have you done a "make distclean" lately?  If not,
> can you do that then remake and rerun flagging and see if you get the same
> results.

-- 
Risto Treksler
Elkhorn Lodge
Banff, Alberta, Canada
-------------- next part --------------
A non-text attachment was scrubbed...
Name: commercial_skip.diff.gz
Type: application/x-gzip
Size: 735 bytes
Desc: not available
Url : http://mythtv.org/pipermail/mythtv-users/attachments/20050411/1263c7bd/commercial_skip.diff.bin


More information about the mythtv-users mailing list