[mythtv-firehose] mythtv branch master updated by dhampton. v30-Pre-292-g546da36

Git Repo Owner noreply at mythtv.org
Fri Nov 3 01:39:16 UTC 2017


The branch, master has been updated on the
mythtv repository by gitolite user dhampton.
       via  546da36a8591ccae8658c0ba37f8fce67c527d6c (commit)
       via  23db439e6569f27c7df26846fdb29dcdaf069e65 (commit)
       via  a7cd35aa778541b0a76e5d5a2e93857e79910a43 (commit)
       via  14e5bccd251f0dd9de50deb0470e5a6b60b6999d (commit)
       via  bc7890fde3b8be114629dfe50c4304b561f4399d (commit)
       via  12d4cd62f6055fc5856f86c397f099d3d19dedb7 (commit)
       via  980b7ea739307713270d60d1752f7f6dfc3d5b33 (commit)
       via  8dbf7a7dcc89c54a77c1361f1c83298e4a97ab5a (commit)
       via  8d8f2182ceded3de45eaf359aeb0854540c53eb7 (commit)
       via  3ae6f99f7b9e355ef13f6dc336405b0822642b28 (commit)
       via  62db0add81276228f019df9cc670c179ae2a9bae (commit)
      from  00641bee2e3377d85a1ef47146c1b2a8e682328e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 546da36a8591ccae8658c0ba37f8fce67c527d6c
Author:    David Hampton <mythtv at love2code.net> at Thu, 2 Nov 2017 21:27:40 -0400
Committer: David Hampton <mythtv at love2code.net> at Thu, 2 Nov 2017 21:35:10 -0400
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=546da36a8591ccae8658c0ba37f8fce67c527d6c

Fix compiler unused parameter warnings in MythUDPListener::Process.
Comment out the variable names to eliminate the warnings.



commit 23db439e6569f27c7df26846fdb29dcdaf069e65
Author:    David Hampton <mythtv at love2code.net> at Thu, 2 Nov 2017 20:51:27 -0400
Committer: David Hampton <mythtv at love2code.net> at Thu, 2 Nov 2017 21:35:09 -0400
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=23db439e6569f27c7df26846fdb29dcdaf069e65

Fix compiler unused parameter warnings in MythRAOPConnection::udpDataReady.
Comment out the variable names to eliminate the warnings.



commit a7cd35aa778541b0a76e5d5a2e93857e79910a43
Author:    David Hampton <mythtv at love2code.net> at Thu, 2 Nov 2017 20:13:54 -0400
Committer: David Hampton <mythtv at love2code.net> at Thu, 2 Nov 2017 21:35:09 -0400
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=a7cd35aa778541b0a76e5d5a2e93857e79910a43

Fix cppcheck badBitmaskChecks in mythdate.cpp.
The code was correct as written.  Create a new constant that maps to
the same two bits in order to silence this warning.



commit 14e5bccd251f0dd9de50deb0470e5a6b60b6999d
Author:    David Hampton <mythtv at love2code.net> at Thu, 2 Nov 2017 19:37:43 -0400
Committer: David Hampton <mythtv at love2code.net> at Thu, 2 Nov 2017 21:35:08 -0400
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=14e5bccd251f0dd9de50deb0470e5a6b60b6999d

Add an UDPPacket and RTPDataPacket operator= functions.
This fixes the cppcheck warnings about having a 'copy constructor'
method without also having a 'operator=' method.



commit bc7890fde3b8be114629dfe50c4304b561f4399d
Author:    David Hampton <mythtv at love2code.net> at Thu, 2 Nov 2017 19:36:48 -0400
Committer: David Hampton <mythtv at love2code.net> at Thu, 2 Nov 2017 21:35:08 -0400
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=bc7890fde3b8be114629dfe50c4304b561f4399d

Add an ActionID::operator= function.
This fixes the cppcheck warning about having a 'copy constructor'
method without also having a 'operator=' method.



commit 12d4cd62f6055fc5856f86c397f099d3d19dedb7
Author:    David Hampton <mythtv at love2code.net> at Thu, 2 Nov 2017 19:32:41 -0400
Committer: David Hampton <mythtv at love2code.net> at Thu, 2 Nov 2017 21:35:08 -0400
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=12d4cd62f6055fc5856f86c397f099d3d19dedb7

Add an DSMCCCacheReference::operator= function.
This fixes the cppcheck warning about having a 'copy constructor'
method without also having a 'operator=' method.



commit 980b7ea739307713270d60d1752f7f6dfc3d5b33
Author:    David Hampton <mythtv at love2code.net> at Thu, 2 Nov 2017 18:56:36 -0400
Committer: David Hampton <mythtv at love2code.net> at Thu, 2 Nov 2017 21:35:07 -0400
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=980b7ea739307713270d60d1752f7f6dfc3d5b33

Fix cppcheck "Condition 'vtp==0' is always true" warning.
The code that would set this variable to a non-zero value is commented
out, so this is a valid warning.  Paring the function down to the only
possible code path would yield a function that always returns NULL.
Instead, #ifdef out the code in case someone ever gets around to
working on it.



commit 8dbf7a7dcc89c54a77c1361f1c83298e4a97ab5a
Author:    David Hampton <mythtv at love2code.net> at Thu, 2 Nov 2017 17:56:46 -0400
Committer: David Hampton <mythtv at love2code.net> at Thu, 2 Nov 2017 21:35:07 -0400
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=8dbf7a7dcc89c54a77c1361f1c83298e4a97ab5a

Fix cppcheck performance warnings in zmserver.
Convert nine string parameters to three functions to usd const string
references instead.



commit 8d8f2182ceded3de45eaf359aeb0854540c53eb7
Author:    David Hampton <mythtv at love2code.net> at Thu, 2 Nov 2017 00:34:27 -0400
Committer: David Hampton <mythtv at love2code.net> at Thu, 2 Nov 2017 21:35:07 -0400
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=8d8f2182ceded3de45eaf359aeb0854540c53eb7

Fix cppcheck warnings for "condition !handled is always true".
These functions appear identical, and all appear to have originally
been copied from a function that handled multiple different events.
When handling multiple events it makes sense to check whether a
previous function call handled an event, but when processing a single
event that test no longer serves any purpose.  These functions all
collapse down nicely.



commit 3ae6f99f7b9e355ef13f6dc336405b0822642b28
Author:    David Hampton <mythtv at love2code.net> at Wed, 1 Nov 2017 21:27:06 -0400
Committer: David Hampton <mythtv at love2code.net> at Thu, 2 Nov 2017 21:35:06 -0400
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=3ae6f99f7b9e355ef13f6dc336405b0822642b28

Remove never used variable in DVDThemeSelector::getThemeList.
The 'count' variable in this function has never been used since the
code was committed in 2006 by 87d19e61.



commit 62db0add81276228f019df9cc670c179ae2a9bae
Author:    David Hampton <mythtv at love2code.net> at Wed, 1 Nov 2017 21:26:47 -0400
Committer: David Hampton <mythtv at love2code.net> at Thu, 2 Nov 2017 21:35:06 -0400
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=62db0add81276228f019df9cc670c179ae2a9bae

Fix cppcheck format string warning in resDurationFormat.
This function manipulates and prints an unsigned integer, so it should
be using the format string for unsigned values.



-----------------------------------------------------------------------

Summary of changes:
 .../mytharchive/mytharchive/themeselector.cpp      |    2 --
 .../mythbrowser/mythbrowser/bookmarkmanager.cpp    |    7 +------
 mythplugins/mythmusic/mythmusic/importsettings.cpp |    7 +------
 .../mythzoneminder/mythzmserver/zmserver.cpp       |   12 +++++++-----
 mythplugins/mythzoneminder/mythzmserver/zmserver.h |   12 +++++++-----
 mythtv/libs/libmythbase/mythdate.cpp               |    4 ++--
 mythtv/libs/libmythbase/mythdate.h                 |    1 +
 .../libs/libmythtv/AirPlay/mythraopconnection.cpp  |    4 ++--
 mythtv/libs/libmythtv/dsmcccache.h                 |    9 +++++++++
 .../libs/libmythtv/recorders/rtp/rtpdatapacket.h   |    7 +++++++
 mythtv/libs/libmythtv/recorders/rtp/udppacket.h    |    7 +++++++
 mythtv/libs/libmythtv/recorders/vbitext/vbi.c      |   11 +++++++++--
 mythtv/libs/libmythui/mythudplistener.cpp          |    4 ++--
 mythtv/libs/libmythupnp/upnphelpers.cpp            |    2 +-
 mythtv/programs/mythfrontend/action.h              |    7 +++++++
 mythtv/programs/mythfrontend/grabbersettings.cpp   |    7 +------
 .../mythfrontend/videometadatasettings.cpp         |    7 +------
 .../programs/mythfrontend/videoplayersettings.cpp  |    7 +------
 18 files changed, 66 insertions(+), 51 deletions(-)

-- 



More information about the mythtv-firehose mailing list