[mythtv-firehose] mythtv branch fixes/0.28 updated by pbennett. v0.28-76-g7f8f168

Git Repo Owner noreply at mythtv.org
Sat Oct 22 16:28:47 UTC 2016


The branch, fixes/0.28 has been updated on the
mythtv repository by gitolite user pbennett.
       via  7f8f1688e882cd0587097fe4867e20d8fa122cce (commit)
       via  89e17dc0d65ca58cb3bcda4765c80986a00e4c71 (commit)
       via  ed7df02899f3a8dbfe67566797168c2f9d9446ce (commit)
       via  c2c1465f474158492f7f7f77f7bf37f64afeb40f (commit)
      from  228b05bd7a8103192957a9abfc0a5baa551e8ba6 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 7f8f1688e882cd0587097fe4867e20d8fa122cce
Author:    Peter Bennett <pbennett at mythtv.org> at Sat, 22 Oct 2016 12:16:00 -0400
Committer: Peter Bennett <pbennett at mythtv.org> at Sat, 22 Oct 2016 12:26:58 -0400
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=7f8f1688e882cd0587097fe4867e20d8fa122cce

Frontend and backend changes to support music choice.
Music choice channels from Comcast are mpeg2 video which internally
identifies as 30 fps but actually sends frames with intervals
5.939, 0.033, 0.033, repeat, ... This amounts to 3 frames at 30fps
every 6 seconds. These frames are never identified as key frames.
Tuning takes up to 8 seconds for these channels on CETON. This
stream breaks several MythTV timeouts, and causes havoc with the
audio-video synchronization routines. It causes the recorder to
report a great many 6 second gaps in the video and mark it as failed.

Fix: Increase timeouts. Increase audio buffer size to allow up to
8 seconds to be buffered. In the backend allow recordings to start with a
non-key frame and set a high threshold for gaps in specific cases.
Change handling of video buffer waits so that audio data is not lost by
audio resets in music choice programs.

Fixes #8096

(cherry picked from commit 2a1ccc06a58af472bd3044bff81dc93c49c83885)



commit 89e17dc0d65ca58cb3bcda4765c80986a00e4c71
Author:    Peter Bennett <pbennett at mythtv.org> at Mon, 10 Oct 2016 15:52:03 -0400
Committer: Peter Bennett <pbennett at mythtv.org> at Sat, 22 Oct 2016 12:26:48 -0400
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=89e17dc0d65ca58cb3bcda4765c80986a00e4c71

Setup change to allow CETON users to set tuning timeout.
The 3 second default tuning timeout is not enough. Many recordings
are marked as failed even though they are successful. Also allow
users who wish to watch music choice to set the timeout
sufficient for those slow to tune channels.

Refs #8096

(cherry picked from commit 2d24c4acbe858cc6eaa3dcb981d46b37b295f892)



commit ed7df02899f3a8dbfe67566797168c2f9d9446ce
Author:    Peter Bennett <pbennett at mythtv.org> at Mon, 10 Oct 2016 15:49:01 -0400
Committer: Peter Bennett <pbennett at mythtv.org> at Sat, 22 Oct 2016 12:24:41 -0400
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=ed7df02899f3a8dbfe67566797168c2f9d9446ce

Fix Seg fault in OSD due to notification being displayed using a painter that is no longer valid.
The OSD goes through all notifications in the notification center
and displays them. Each notification screen has a painter stored in
it. The painter will be invalid if the notification started being
displayed before the playback started or before an inputchanged
notification caused it to be deleted

Exception Details:
1   in MythUIType::HandleMovementPulse at mythuitype.cpp:374
...
3   in OSD::DrawDirect at osd.cpp:702

Fix: Always update the painter to the latest one before painting
notifications.

Refs #8096

(cherry picked from commit 5b011ca7e7706efe15e21d6435be72429b50194f)



commit c2c1465f474158492f7f7f77f7bf37f64afeb40f
Author:    Peter Bennett <pbennett at mythtv.org> at Mon, 10 Oct 2016 15:43:38 -0400
Committer: Peter Bennett <pbennett at mythtv.org> at Sat, 22 Oct 2016 12:24:40 -0400
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=c2c1465f474158492f7f7f77f7bf37f64afeb40f

Fix Seg Fault due to OSD painter being deleted while image loader threads are still using it.
Image loading for the OSD uses ImageLoadThread and continues
loading while the video is playing. If the video playback
encounters an "InputChanged" situation it deletes the OSD and its
painter and re-creates it.  If the Image load is still running and
using the painter, it gets a Seg Fault calling a virtual function
using a corrupted object

Exception Details:
1   in MythPainter::GetFormatImage at mythpainter.cpp:540

Fix: Keep the old osd painter valid until either it changes again
or the OSD is deleted.

Refs #8096

(cherry picked from commit 28fe92a74d0cd903ad0c154fa3cd9a74019d1ca8)



-----------------------------------------------------------------------

Summary of changes:
 mythtv/libs/libmyth/audio/audiooutputbase.cpp   |    2 +-
 mythtv/libs/libmyth/audio/audiooutputbase.h     |    3 +-
 mythtv/libs/libmythtv/audioplayer.cpp           |    2 +-
 mythtv/libs/libmythtv/mythplayer.cpp            |   35 ++++++++++++++++++----
 mythtv/libs/libmythtv/mythplayer.h              |    3 ++
 mythtv/libs/libmythtv/osd.cpp                   |    3 ++
 mythtv/libs/libmythtv/recorders/dtvrecorder.cpp |   16 +++++++++-
 mythtv/libs/libmythtv/recorders/dtvrecorder.h   |    4 ++
 mythtv/libs/libmythtv/ringbuffer.cpp            |    8 ++--
 mythtv/libs/libmythtv/videoout_d3d.cpp          |    9 +++++-
 mythtv/libs/libmythtv/videoout_opengl.cpp       |    9 +++++-
 mythtv/libs/libmythtv/videoout_vdpau.cpp        |    9 +++++-
 mythtv/libs/libmythtv/videooutbase.cpp          |    4 ++
 mythtv/libs/libmythtv/videooutbase.h            |    2 +
 mythtv/libs/libmythtv/videosource.cpp           |   35 +++++++++++++++++++++++
 mythtv/libs/libmythtv/videosource.h             |    5 +++
 16 files changed, 130 insertions(+), 19 deletions(-)

-- 



More information about the mythtv-firehose mailing list