[mythtv-firehose] mythtv branch master updated by gigem. v0.28-pre-1436-g8116fde

Git Repo Owner noreply at mythtv.org
Fri May 30 19:47:17 UTC 2014

The branch, master has been updated on the
mythtv repository by gitolite user gigem.
       via  8116fde7f46494dda0c7ca7658c3bf22e9340b34 (commit)
      from  639771919a3d5577cc8235034dd379724c860713 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 8116fde7f46494dda0c7ca7658c3bf22e9340b34
Author:    David Engel <dengel at mythtv.org> at Fri, 30 May 2014 14:33:51 -0500
Committer: David Engel <dengel at mythtv.org> at Fri, 30 May 2014 14:46:25 -0500
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=8116fde7f46494dda0c7ca7658c3bf22e9340b34

Try to fix corner cases when stopping in-progress recordings.
The backend uses EncoderLink::MatchesRecording(), which in turn uses
ProgramInfo::IsSameRecording(), to determine which recorder to stop.
Unfortunately the logic used is too strict in some respects and too
loose in others.  It is too strict in that it requires an exact match
on ProgramInfo::recstartts when there are many places in the code
where the exact recstartts used by the recorder is not known.  The
result is the stop recording request is ignored in those cases.  It is
too loose in that it doesn't only uses chanid and recstartts.  The
result is that it can stop the wrong recording in some cases.

This change attempts to resolve at least some of the issues.  Changed
PI:IsSameRecording() to also check the program title.  Changed
EL::MatchesProgram() to check PI::IsSameProgramWeakCheck() and the
inputids instead of PI::IsSameRecording() when the inputid is known.
This handles the cases where the exact recstartts isn't known.
Finally, removed a work-around for this problem in ScheduleCommon that
didn't always work.


Summary of changes:
 mythtv/libs/libmyth/programinfo.h               |    4 +++-
 mythtv/programs/mythbackend/encoderlink.cpp     |    6 +++++-
 mythtv/programs/mythfrontend/schedulecommon.cpp |    5 +----
 3 files changed, 9 insertions(+), 6 deletions(-)


More information about the mythtv-firehose mailing list