[mythtv-firehose] mythtv branch master updated by stuartm. v0.26-pre-385-g9bddf5b

[Git Repo Owner]

The branch, master has been updated on the
mythtv repository by gitolite user stuartm.
       via  9bddf5b26c5cf7e514e336de2ea4791031326cbe (commit)
       via  7533cf25dcc02c127ccb1b201d69d1d6d4ff5d9e (commit)
       via  10d1cc6dc58208a383417c3d8b83415266d1b864 (commit)
       via  a6d45b140ba55f3f9955e3ff7ea7e7169774723c (commit)
       via  502f0b0538863e6f1501d0aa2ac673c0ff816294 (commit)
      from  84974039959d2372844a39a820ca4c7530df5a58 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 9bddf5b26c5cf7e514e336de2ea4791031326cbe
Author:    Stuart Morgan <smorgan at mythtv.org> at Thu, 24 May 2012 19:51:26 +0100
Committer: Stuart Morgan <smorgan at mythtv.org> at Thu, 24 May 2012 19:51:26 +0100
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=9bddf5b26c5cf7e514e336de2ea4791031326cbe

Fix a null pointer dereference in MainServer::HandleQueryRecording(). This bug would have made it possible to crash a backend with a malformed QUERY_RECORDING message. Coverity defect 700420



commit 7533cf25dcc02c127ccb1b201d69d1d6d4ff5d9e
Author:    Stuart Morgan <smorgan at mythtv.org> at Thu, 24 May 2012 19:46:57 +0100
Committer: Stuart Morgan <smorgan at mythtv.org> at Thu, 24 May 2012 19:47:22 +0100
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=7533cf25dcc02c127ccb1b201d69d1d6d4ff5d9e

Always check the return value of QSqlQuery::next() before accessing results in MainServer. Ee only needed to check next() in these instances, the isActive() and size() calls were redundant and have been removed. Coverity defects 700273 and 700274.



commit 10d1cc6dc58208a383417c3d8b83415266d1b864
Author:    Stuart Morgan <smorgan at mythtv.org> at Thu, 24 May 2012 19:39:05 +0100
Committer: Stuart Morgan <smorgan at mythtv.org> at Thu, 24 May 2012 19:47:22 +0100
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=10d1cc6dc58208a383417c3d8b83415266d1b864

Always check the return value of QSqlQuery::next() before accessing results in the Housekeeper. In fact we only needed to check next() in these instances, the isActive() and size() calls were redundant. Coverity defects 700272 and 700271.



commit a6d45b140ba55f3f9955e3ff7ea7e7169774723c
Author:    Stuart Morgan <smorgan at mythtv.org> at Thu, 24 May 2012 19:27:33 +0100
Committer: Stuart Morgan <smorgan at mythtv.org> at Thu, 24 May 2012 19:47:22 +0100
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=a6d45b140ba55f3f9955e3ff7ea7e7169774723c

Change 0 to NULL for pointers per MythTV coding standards



commit 502f0b0538863e6f1501d0aa2ac673c0ff816294
Author:    Stuart Morgan <smorgan at mythtv.org> at Thu, 24 May 2012 19:16:44 +0100
Committer: Stuart Morgan <smorgan at mythtv.org> at Thu, 24 May 2012 19:47:21 +0100
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=502f0b0538863e6f1501d0aa2ac673c0ff816294

Re-organise some things to stop Coverity et al warning about possible null pointer dereferences in mythfrontend.



-----------------------------------------------------------------------

Summary of changes:
 mythtv/programs/mythbackend/housekeeper.cpp     |   12 ++++--------
 mythtv/programs/mythbackend/mainserver.cpp      |   15 +++++++--------
 mythtv/programs/mythfrontend/playbackbox.cpp    |    2 +-
 mythtv/programs/mythfrontend/videodlg.cpp       |   12 +++++++-----
 mythtv/programs/mythfrontend/videofileassoc.cpp |    2 +-
 mythtv/programs/mythfrontend/videolist.cpp      |    4 ++--
 6 files changed, 22 insertions(+), 25 deletions(-)

--