[mythtv] [mythtv-commits] [MythTV/mythtv] 6227eb: MythUIHelper: Add GetGeometryOverride method

[John Pilkington]

On 14/01/2020 13:32, Mark Kendall wrote:
>    Branch: refs/heads/master
>    Home:   https://github.com/MythTV/mythtv
>    Commit: 6227ebed53256d500b22a7bfab6c65a02e352f45
>        https://github.com/MythTV/mythtv/commit/6227ebed53256d500b22a7bfab6c65a02e352f45
>    Author: Mark Kendall <mark.kendall at gmail.com>
>    Date:   2020-01-14 (Tue, 14 Jan 2020)
> 
>    Changed paths:
>      M mythtv/libs/libmythtv/tv_play.cpp
>      M mythtv/libs/libmythui/mythuihelper.cpp
>      M mythtv/libs/libmythui/mythuihelper.h
>      M mythtv/libs/libmythui/mythvirtualkeyboard.cpp
> 
>    Log Message:
>    -----------
>    MythUIHelper: Add GetGeometryOverride method
> 
> - and simplify GetScreenSettings a little
> 
> 
>    Commit: 4ca943c4b38a1a2e1f7f436e986423e2c6f13abc
>        https://github.com/MythTV/mythtv/commit/4ca943c4b38a1a2e1f7f436e986423e2c6f13abc
>    Author: Mark Kendall <mark.kendall at gmail.com>
>    Date:   2020-01-14 (Tue, 14 Jan 2020)
> 
>    Changed paths:
>      M mythtv/libs/libmythui/mythdisplay.cpp
> 
>    Log Message:
>    -----------
>    MythDisplay: Attempt to find QScreen for overridden geometry
> 
> - this is fairly crude, though seems to get it correct for simple
> testing with Gnome/X11
> - as noted in the code, there are a raft of potential pitfalls and
> settings that might not produce the expected behaviour.
> 
> 
> Compare: https://github.com/MythTV/mythtv/compare/9edb85e91ea8...4ca943c4b38a

Hi Mark:  It looks as if this is aimed at my use of the --geometry 
override.  Thanks for looking at it.

I'm sorry that my comments about that in #13548 didn't seem helpful. 
They were really intended to share a way of getting good results from 
the existing code, rather than pointing to improvements.

That being said, the same -display=HPFed:0.0 option still (9edb85e) 
gives videos with the right aspect ratio and in the right place on both 
my displays;  without it the windowed video is centred and about 90% of 
the right height.

I had tried various combinations of screen names without getting things 
right.  Another rebuild in hand...

Regards,

John