[mythtv] Inconsistencies in code recommendations regarding if/else bodies

Gary Buhrmaster gary.buhrmaster at gmail.com
Sat Aug 29 16:24:42 UTC 2020


For quite some time now ctidy has been
reporting:

  "warning: statement should be inside braces
[readability-braces-around-statements]"

and various codes in the project have been
updated accordingly.

HOWEVER, in the coding standards
documentation at:

  https://www.mythtv.org/wiki/Coding_Standards

it explicitly says:

  "One-line if or else bodies do not need braces."

Since this would appear to be a change in the
projects coding standards (it now does need
the braces?), the person who made that change
should likely update the wiki (or the ctidy checks
if the braces are still not a hard requirement) so
that future contributors know how to properly
write their code.

Thanks.


More information about the mythtv-dev mailing list