[mythtv] AVSync2 Refinements

Tim Pletcher pletchtd at gmail.com
Wed Dec 11 14:28:33 UTC 2019


On Wed, Dec 11, 2019 at 9:22 AM Mark Kendall <mark.kendall at gmail.com> wrote:

> On Wed, 11 Dec 2019 at 14:14, Tim Pletcher <pletchtd at gmail.com> wrote:
> > Hi Mark,
> >
> > I added the filter in with a second patch and posted on the ticket last
> evening.  I saw this was picked up and rolled into master just a bit ago.
>
> Tim
>
> Thanks again for looking at this.
>
> Did you spot my comment in the commit re the change to 0.4 for
> s_av_control_gain? Was that the correct call? :)
>
>
I think this value should remain as 0.04.

Tim

> >
> > I think this would require changing line 1709 in mythplayer.cpp from
> this:
> > avsync_avg = static_cast<int>(audio_adjustment * 1000);
> > to this:
> > avsync_avg = static_cast<int>(last_fix * 1000 / s_av_control_gain);
> >
>
> I think we should be showing the filtered value.
>
>
I also think this makes sense.

Tim
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mythtv.org/pipermail/mythtv-dev/attachments/20191211/7c922db7/attachment.htm>


More information about the mythtv-dev mailing list