[mythtv] Decision on FFmpeg repository

[Peter Bennett]

On 05/17/2018 01:14 PM, Paul Harrison wrote:
>>> You can see an example of FFmpeg with patches applied at 
>>> https://github.com/bennettpeter/FFmpeg
>> For 2c, would it not be easier to use a submodule instead of manually 
>> copying files from one repo to the other?  I think I prefer that over 
>> 2b.
>>
>> Jonatan
>>
>
> Using a submodule would be my choice as well.
>
> Paul H.

My concern with submodules is

1. You have to run "git submodule init" when you first clone or when you 
add a submodule.
2. You have to run "git submodule update" after "git pull" or when there 
are submodule changes.
3. A commit hash may no longer identify what source code was used for a 
build, because you cannot tell if they remembered to update the 
submodule. I suppose we need to add a submodule hash to the version string.

The need to update the submodule will affect developers and build scripts.

Is this all correct? I have not used submodules, just read the 
documentation. Any ideas on how to approach notifying everybody who may 
be affected? Perhaps start 2c with the copy and give everybody some 
period of time to add the necessary submodule code to build scripts, 
then switch to the submodule.

Peter
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mythtv.org/pipermail/mythtv-dev/attachments/20180517/c39bf2e0/attachment.html>