[mythtv] [PATCH] WebFrontend: Fix icon sprite locations in CSS

Paul Harrison mythtv at sky.com
Mon May 7 09:03:10 UTC 2018


On 06/05/18 18:37, Bill Meek wrote:

> On 05/05/2018 06:02 AM, Philipp Matthias Hahn wrote:
>> All 'background-position's must be given as *negative* values, as it
>> describes the start position relative to the top-left corner of the HTML
>> element where painting the background images starts.
>> ---
>>   mythtv/html/tv/css/icons.css | 14 +++++++-------
>>   1 file changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/mythtv/html/tv/css/icons.css b/mythtv/html/tv/css/icons.css
>> index 2ccf64e74a..5ca5c0a20a 100644
>> --- a/mythtv/html/tv/css/icons.css
>> +++ b/mythtv/html/tv/css/icons.css
>> @@ -13,35 +13,35 @@
>>     .icon_flautoexpire
>>   {
>> -    background-position: 108px 0px;
>> +    background-position: -36px 0px;
>>   }
>>     .icon_flbookmark
>>   {
>> -    background-position: 72px 0px;
>> +    background-position: -72px 0px;
>>   }
>>     .icon_flcommflag
>>   {
>> -    background-position: 108px 0px;
>> +    background-position: -108px 0px;
>>   }
>>     .icon_flwatched
>>   {
>> -    background-position: 0px 27px;
>> +    background-position: 0px -27px;
>>   }
>>     .icon_hd720
>>   {
>> -    background-position: 36px 27px;
>> +    background-position: -36px -27px;
>>   }
>>     .icon_hd1080
>>   {
>> -    background-position: 72px 27px;
>> +    background-position: -72px -27px;
>>   }
>>     .icon_hdtv
>>   {
>> -    background-position: 108px 27px;
>> +    background-position: -108px -27px;
>>   }
>
> Tested on Chromium 65.0 and Vivaldi 1.16 fine (also
> on an Android phone/Chrome 66.0.)
>
> Does this need testing on other browsers before
> committing?
>

Might be worth asking the opinion of Stuart Morgan since he did all the 
work on the WebFrontend. Don't know if he still does but he used to hang 
out on IRC all the time but not seen or heard much from him in a while.

Paul H.


More information about the mythtv-dev mailing list