[mythtv] Key mapping for BOOKMARK

faginbagin mythtv at hbuus.com
Thu Mar 15 20:19:36 UTC 2018


On 3/15/2018 8:10 AM, Michael T. Dean wrote:
> On 03/13/2018 02:44 PM, Peter Bennett wrote:
>> During playback, the select key assigned in global key mapping is used
>> for setting and removing bookmarks.
> 
> Yes, it's an action "override" (where you tell MythTV to do
> something--SELECT--and it does something else, though in this case the
> something else is at least reasonable as it's selecting that location
> for the bookmark) and is modified via a setting:
> 
> Alternate clear and save bookmark
> During playback the SELECT key (Enter or Space) will alternate between
> "Bookmark Saved" and "Bookmark Cleared". If disabled, the SELECT key
> will save the current position for each keypress.
> 
> You'll need to handle this, also, when you modify.  Since a setting
> shouldn't modify key behavior (so that users can map both behaviors, if
> desired), we really should have a separate action for SET_BOOKMARK
> (always sets the current location as the bookmark) and TOGGLE_BOOKMARK
> (which alternates between setting and clearing) rather than just keeping
> the setting and changing a generic action (BOOKMARK) to set or toggle
> based on the setting--which is a problem for users who want both actions
> available.
> 
>> To allow users to set a different key for bookmarks without having to
>> change global select, I have create a new key mapping for bookmarks.
> 
> Creating a new action for setting bookmarks is good.  All actions should
> be separately modifiable, exactly for the reason you describe.
> 
>> I can default this to the same keys as SELECT (i.e. space, enter,
>> return) and it should not affect anybody unless they have changed
>> their global select settings. (see
>> https://code.mythtv.org/trac/attachment/ticket/13234/20180313_1414_bookmark.patch).
>> It is not committed yet.
> 
> This--the "unless they have changed their global settings" part--is one
> reason why...
> 
>> Personally I never set a bookmark and the fact that it is on the most
>> prominent keyboard keys seems inappropriate.
>>
>> On the Nvidia Shield there is only one button (enter), and it should
>> do something useful that leads to other interactions, rather than set
>> a bookmark. Other remotes also have a prominent enter button, which
>> should be used for something more important.
>>
>> I propose defaulting the new BOOKMARK setting to Ctrl+K (since K is
>> "jump to bookmark").
> 
> ...our approach in the past has generally been to not provide a default
> key binding for any new actions added to MythTV because the chosen
> key(s) may conflict with a user-mapped binding.  See
> https://lists.gt.net/mythtv/dev/266100#266100 .  Based on the responses
> in this thread--suggesting few people use SELECT to set a bookmark--I
> would consider this to be a not significant case. Therefore, having an
> empty default keylist for SET_BOOKMARK and for TOGGLE_BOOKMARK would
> make sense since there are other approaches by which the user can set a
> bookmark (even by just exiting playback).

Please do not make assumptions about how many people use this feature
based on replies to this thread. This is the developers' list. We are
not a representative set of users. Ask the users' list or forum if you
want to get a more realistic idea of how may USERS care about this feature.

<snip>


More information about the mythtv-dev mailing list