[mythtv] Testers Wanted for New, ON-Deman Input Feature

[Mark Perkins]

On 11 January 2018 1:12:14 pm Bill Meek <keemllib at gmail.com> wrote:

> On 01/09/2018 04:17 PM, David Engel wrote:
>> On Tue, Jan 09, 2018 at 03:18:23PM -0600, Bill Meek wrote:
>>> On 01/09/2018 10:41 AM, Bill Meek wrote:
>>>> On 01/08/2018 10:51 AM, David Engel wrote:
>>>
>>> ...
>>>
>>>>> Do I have any other takers on this?
>>>>>
>>>>> David
>>>>>
>>>>
>>>> I'm in. Just got my test host's systemd setup so the backend can be started
>>>> as a master or as a slave to my production host. I've only got one channel
>>>> eligible for multirec right now, but multirec works on master. Switching to
>>>> the devel/scheduler branch now.
>>>
>>> Well, this didn't last long. My production backend is still on Ubuntu 14.04
>>> and Qt 5.2.1. This branch builds on 17.10, but on 14.04 fails with:
>
>>>...
>
>>> -I/usr/include/qt5/QtCore -Imoc -o obj/main_helpers.o main_helpers.cpp
>>> main_helpers.cpp: In function ‘bool setupTVs(bool, bool&)’:
>>> main_helpers.cpp:156:36: error: invalid use of qualified-name 
>>> ‘TVRec::inputsLock’
>>>       QWriteLocker(&TVRec::inputsLock);
>>>                                      ^
>>> make[2]: *** [obj/main_helpers.o] Error 1
>>> make[2]: Leaving directory 
>>> `/home/bill/source/mythtv/mythtv/programs/mythbackend'
>>> make[1]: *** [sub-mythbackend-make_first] Error 2
>>> make[1]: Leaving directory `/home/bill/source/mythtv/mythtv/programs'
>>> make: *** [programs] Error 2
>>>
>>> And I've not been able to solve the above. Did a distclean before the above.
>>> I'll switch back to master but would be happy to test any suggestions to get
>>> past the above.
>>
>> I don't know why that error is occurring.  Is that the only one you're
>> getting?  If so, could you try replaceing the QWriteLocker with calls
>> to lockForWrite() and unlock()?
>
> David,
>
> Yes, it was the only error. I see that there are 35 other uses of QWriteLocker
> in master, so I changed the one above like this:
>
> diff --git a/mythtv/programs/mythbackend/main_helpers.cpp 
> b/mythtv/programs/mythbackend/main_helpers.cpp
> index 7c4567a..ae73bbb 100644
> --- a/mythtv/programs/mythbackend/main_helpers.cpp
> +++ b/mythtv/programs/mythbackend/main_helpers.cpp
> @@ -153,7 +153,7 @@ bool setupTVs(bool ismaster, bool &error)
>           hosts.push_back(host);
>       }
>
> -    QWriteLocker(&TVRec::inputsLock);
> +    QWriteLocker lock(&TVRec::inputsLock);
>
>       for (uint i = 0; i < cardids.size(); i++)
>       {
>
> and it builds OK. Just recorded a single scheduled program OK.
>
> I'll just do my normal scheduled recordings tonight, no multirec or
> slave backend online.
>
> Does the above change meet your needs?
>
> --
> Bill
>

I've got the same build error. I'll make the change proposed by Bill.