[mythtv] Ticket #12809: Use lastPlayPos rather than bookmark

Roger Siddons dizygotheca at ntlworld.com
Wed Jan 10 23:15:55 UTC 2018


On Wed, 10 Jan 2018 16:11:27 -0500
Peter Bennett <pb.mythtv at gmail.com> wrote:

> On 01/10/2018 01:07 PM, Peter Bennett wrote:
> 
> I think it is easier to update the existing SetSavedBookmark service
> to have an extra optional parameter BookmarkType that can take value 
> "lastplaypos" to update last play position. Since it is optional it
> will continue to work without that parameter for existing
> applications that update the bookmark.
> 

Nice.

In another thread I've been wondering about allowing multiple bookmarks.
This patch doesn't look so clever now - it's predicated on a
single bookmark.

GetRecordedCommBreak & GetRecordedCutList both use a "Mark" int
already. I don't particularly like the 'int', but if we're going to use
it for the setter maybe GetMarks should simply return a CutList as well.
It would contain a list of all relevant marks except commflag/cutlist
ones. That would be more consistent & future-proof.

The client would have to search for a specific mark but that's not
onerous. And we can get rid of the new "Marks" type.

ints/enums in the API aren't ideal. We already use
"position"/"duration" so why not report the mark type as a string as
well ? There's a programtypes::toString already. 
The strings would become part of the API spec but I think that would be
better than obscure ints. We need a way to document them though.

If you mail me your latest patch, I'll rework it.


More information about the mythtv-dev mailing list