[mythtv] FFmpeg seg fault in mediacodec patch
aman at tmm1.net
Fri Aug 3 18:08:52 UTC 2018
On Thu, Jul 19, 2018 at 10:04 AM Peter Bennett <pb.mythtv at gmail.com> wrote:
> Hi Aman
> I resubmitted the patch.
> I hope I did a better job this time. I did a compare and the
> mediacodec_sw_buffer.c file in my MythTV repository is now identical to the
> one in my FFmpeg repository after the patch.
FYI I've committed a different fix for this bug to ffmpeg master and
> On 07/19/2018 12:42 PM, Aman Gupta wrote:
> Yes please submit the fixed patch to the list.
> On Thu, Jul 19, 2018 at 9:41 AM Peter Bennett <pb.mythtv at gmail.com> wrote:
>> Hi Aman
>> The original patch is correct. Sorry. I need a better process for this.
>> The patch from MythTV does not apply in FFmpeg because of the different
>> path, so I changed it manually, wrongly. I will fix that. Can I resubmit
>> the patch once fixed?
>> On 07/19/2018 12:11 PM, Aman Gupta wrote:
>> Hi Peter,
>> The patch you submitted to the list changes
>> ff_mediacodec_sw_buffer_copy_yuv420_planar, but the patch you sent me
>> above changes ff_mediacodec_sw_buffer_copy_yuv420_semi_planar
>> Which one is correct?
>> On Wed, Jul 18, 2018 at 12:06 PM Aman Gupta <aman at tmm1.net> wrote:
>>> Please submit to ffmpeg-devel so others can review. I will commit if
>>> there are no objections there.
>>> On Wed, Jul 18, 2018 at 12:03 PM Peter Bennett <pb.mythtv at gmail.com>
>>>> Hi Aman
>>>> This patch fixes the seg fault in mediacodec with 1080i playback on
>>>> android oreo. Also I have confirmation from others who have tried it
>>>> that it does not cause any issue with earlier android versions. Please
>>>> can you get it committed to FFmpeg. See attached file.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the mythtv-dev