[mythtv] Mythtv-setup looks too often for VBoxes

[Nigel Pearson]

> On 24 Aug 2017, at 5:37 am, John Pilkington <J.Pilk at tesco.net> wrote:
> 
> mythtv/programs/mythtv-setup/main.cpp  has, at line 366,
> 
>    if (!cmdline.toBool("noupnp"))
>    {
>        // start looking for any uPnP devices we can use like VBoxes
>        SSDP::Instance()->PerformSearch("ssdp:all");
>    }



Other occurrences also:

% egrep 'noupnp"' */*.cpp
mythbackend/main_helpers.cpp:        g_pUPnp->Init(ismaster, cmdline.toBool("noupnp"));
mythfrontend/main.cpp:    if (!cmdline.toBool("noupnp"))
mythtv-setup/main.cpp:    if (!cmdline.toBool("noupnp"))
% 

and:

% cat libs/libmythbase/mythcommandlineparser.cpp
. . .
/** \brief Canned argument definition for --noupnp
 */
void MythCommandLineParser::addUPnP(void)
{
    add("--noupnp", "noupnp", false, "Disable use of UPnP.", "");
}





> but I don't see a direct way of passing 'noupnp' from
> 
> mythtv/programs/mythtv-setup/commandlineparser.cpp
> 
> Am I looking in the right place?  Can it be done?


GitHub search for addUPnP -

I suspect that file just needs an addUPnP();
in  MythBackendCommandLineParser::LoadArguments() ???



--
Nigel Pearson, nigel at ind.tansu.com.au|"Reality is that which,  |
Telstra Voice/Vid, Sydney, Australia | when you stop believing |
Office: 8576 5449    Fax:  9298 9033 | in it, doesn't go away."|
Mobile: 0408 664435  Home: 9792 6998 | Philip K. Dick - 'Valis’|



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mythtv.org/pipermail/mythtv-dev/attachments/20170901/1ec8ebe4/attachment.html>