[mythtv] [mythtv-commits] Ticket #154: mythconverg.cardinput.startchan being written as NULL

[Peter Bennett]

On 10/11/2017 08:26 AM, David Hampton wrote:
> On Wed, 2017-10-11 at 09:53 +0100, Paul Harrison wrote:
>> Perhaps best not to reference the github ticket numbers, or
>> obfuscate the #12345 part, since the commit hook is confused
>> by it and references trac tickets by mistake like this one.
> Hi Paul,
>
> GitHub didn't notice that my first two commits closed pull requests,
> and there's no way to manually mark a PR as committed and closed.  (I
> can manually close it, but then github says its closed but not fixed.
> I asked github tech support about a manual method to mark a PR as
> committed.  There isn't one.)  After talking to stuarta I started
> adding github PR numbers so that the github integration would close the
> PRs properly.  That's how I got into trouble with trac.  Do you have
> any suggestions on how I can get both the trac ticket and github PR
> closed?  I'd love to know what I'm doing wrong, or how to make both
> systems happy.  Thanks.
>
> David
>
>
Hi David
I have found that as long as you use a merge from the originating 
repository branch into the mythtv repo, the github pull request 
automatically gets closed. If you use cherry-pick or other methods of 
getting it in, the pull request does not get closed. (see 
https://code.mythtv.org/trac/wiki/GitHubPullRequests)
Peter