[mythtv] 3db436fd953d1bdc7176b05f3ea05fceccdd1d5a breaks OS X playback

[Peter Bennett]

On 03/18/2017 10:28 AM, Piotr Oniszczuk wrote:
> Peter,
> this commit breaks playback on OS X me.
> FE log says:
>
> 2017-03-18 15:16:24.838308 I  TV::TV(): Creating TV object
> 2017-03-18 15:16:24.889064 N  Suspending idle timer
> 2017-03-18 15:16:24.910303 I  TV::Init(): Created TvPlayWindow.
> 2017-03-18 15:16:24.955164 I  TV::HandleStateChange(): Attempting to change from None to WatchingPreRecorded
> 2017-03-18 15:16:25.275881 W  CoreAudioData Warning:CoreAudioData: "" not found, using default device 46.
> 2017-03-18 15:16:25.285671 N  AudioPlayer: Enabling Audio
> 2017-03-18 15:16:26.035255 I  AFD: codec MP2 has 2 channels
> 2017-03-18 15:16:26.035349 I  AFD: Opened codec 0x7fb6b5884000, id(MP2) type(Audio)
> 2017-03-18 15:16:26.035486 I  AFD: codec MP2 has 2 channels
> 2017-03-18 15:16:26.035523 I  AFD: Opened codec 0x7fb6b5a90e00, id(MP2) type(Audio)
> 2017-03-18 15:16:26.035567 I  AFD: Opened codec 0x7fb6b5a7b400, id(DVB_SUBTITLE) type(Subtitle)
> 2017-03-18 15:16:26.077459 I  AFD: Opened codec 0x7fb6b5c3c600, id(H264) type(Video)
> 2017-03-18 15:16:26.096648 I  AOBase: Opening audio device '' ch 2(2) sr 48000 sf signed 16 bit reenc 0
> 2017-03-18 15:16:26.110775 W  CoreAudioData Warning:Audio device is not configured. You should configure your speaker layout with the "Audio Midi Setup" utility in /Applications/Utilities.
> 2017-03-18 15:16:26.493435 E  VidOutGL: Unable to use OpenGL when ThemePainter is set to QT.
> 2017-03-18 15:16:26.505778 E  VideoOutput: Not compiled with any useable video output method.
> 2017-03-18 15:16:26.505794 E  Player(0): Couldn't create VideoOutput instance. Exiting..
> 2017-03-18 15:16:26.505806 E  Player(0): Unable to initialize video.
> 2017-03-18 15:16:26.533652 E  playCtx: StartPlaying() Failed to start player
> 2017-03-18 15:16:26.533706 C  TV::StartPlayer(): Failed to create player.
> 2017-03-18 15:16:26.534618 I  TV::HandleStateChange(): Main UI disabled.
> 2017-03-18 15:16:26.534666 I  TV::StartTV(): Entering main playback loop.
> 2017-03-18 15:16:26.548558 I  TV::StartTV(): Exiting main playback loop.
> 2017-03-18 15:16:26.611063 N  Resuming idle timer

Hi Piotr

There are two related commits here

  3db436f : Prevent segfault when OpenGL is set on remote X11 session.
e9daa4e : Fix frontend failure when using QT painter with OpenGL video

Can you confirm for me:
You are not connecting remotely and trying playback (that is one thing 
this tries to prevent)
What is the value of the environment variable DISPLAY before you run the 
frontend?

This is how DISPLAY is checked in this case:
DISPLAY not set should allow playing
DISPLAY=:x or DISPLAY=unix:x should allow playing
DISPLAY=hostname:x should prevent playing (this indicates remote login)

I think DISPLAY maybe used differently in OSX
I can bypass the checks in OSX if they are not working there.

Maybe you can check the scenarios for me on OSX using a version that 
does not include either of the above 2 commits (e.g. fixes/0.28 or a 
build before e9daa4e):

1. If you set ThemePainter to QT and Video display profile is set to 
OpenGL, can you successfully play recordings and videos? With Linux you 
cannot, the video is invisible, you just hear the audio and there are 
thousands of error messages in the log.
2. If you set Themepainter to OpenGL can you open the frontend remotely 
from another terminal using ssh and X11 forwarding? With Linux that 
causes a segfault.

if case 2. if the frontend will not open successfully please check the 
value of DISPLAY on local and remote sessions so that I can use 
appropriate checks.

Peter