[mythtv] ttvdb v2 support for 0.27 (and IPv6)

[faginbagin]

On 8/29/2017 8:22 AM, Peter Bennett wrote:
> 
> 
> On 08/29/2017 12:06 AM, faginbagin wrote:
>> Thanks for the reassurance. Just to be sure we're on the same page. 
>> the 0.27 code in mythtv/bindings/python/MythTV/database.py, starting 
>> around line 1359, with these lines:
>>
>>     def _getpreferredaddr(self, host):
>>         ip6 = self.settings[host].BackendServerIP6
>>         ip4 = self.settings[host].BackendServerIP
>>
>> didn't work for IPv6? If they did work, it should be OK, because I 
>> preserved them, not the later code that replaced 8 lines with just 
>> this one:
>>
>>         return self.settings[host].BackendServerAddr
>>
>> Regards,
>> Helen
> That one line will only work in v29. That BackendServerAddr was only 
> introduced in v29. I recommend you look at the v0.28 versions of the 
> bindings for backporting to 0.27. Did you try just cherry-picking the 
> commit into fixes/0.27?
> 
> Peter

Sorry it's taken me a couple of days to reply, life ...

I think we are having a "failure to communicate". I understand that 
BackendServerAddr does not exist in 0.27, but BackendServerIP and 
BackendServerIP6 does exist and that the ability to connect to the 
backend via IPv6 was supposedly supported since 0.25. I was asking for 
clarification about database.py because you said:

"In v0.27, without those changes, the database connection did not work 
on IPV6 anyway. So as long as it still works on IPV4 you will not impact 
anybody."

However, the code in question in database.py was not for connecting to 
the database (e.g. mysqld), it was for finding the right IP address to 
connect to the master backend. So I was, in essence, asking; Are you 
sure the code in question did not support connecting to the backend over 
IPv6?

As for how I brought in Mark's changes, I did it before his pull request 
was accepted. So I generated a pull request from his fork to mine, 
brought it into a branch off of master on my fork, created a new branch 
off of 0.27 and then cherry picked his commits into that branch. Feel 
free to check my work.

Branch off of master containing Mark's unadulterated commits:
https://github.com/faginbagin/mythtv/tree/mspieth-ttvdb-api-v2

Branch off of 0.27 containing those commits after cherry-picking and 
resolving conflicts.
https://github.com/faginbagin/mythtv/tree/0.27-ttvdb-api-v2

Regards,
Helen