[mythtv] MythTV Raspberry Pi2 frontend testers

[Lawrence Rust]

On Sat, 2015-11-28 at 20:04 +0000, Thomas Mashos wrote:
[snip]
> I think we're getting closer. It's finding everything now but still failing
> on the build. Looks like it's failing on videoout_omx.o. Build snippet
> below. Full build log at
> https://launchpadlibrarian.net/227870406/buildlog_ubuntu-wily-armhf.mythtv_2%3A0.27.5%2Bfixes.20151128.54a9cda-0ubuntu1_BUILDING.txt.gz
> 
> In file included from /opt/vc/include/interface/vcos/vcos.h:116:0,
>                  from /opt/vc/include/interface/vmcs_host/vc_dispmanx.h:33,
>                  from /opt/vc/include/bcm_host.h:50,
>                  from videoout_omx.cpp:14:
> /opt/vc/include/interface/vcos/pthreads/vcos_platform.h: In function
> 'void vcos_event_signal(VCOS_EVENT_T*)':
> /opt/vc/include/interface/vcos/pthreads/vcos_platform.h:535:8:
> warning: variable 'ok' set but not used [-Wunused-but-set-variable]
>     int ok = 0;
>         ^
> videoout_omx.cpp: In member function 'virtual bool
> VideoOutputOMX::CanVisualise(AudioPlayer*, MythRender*)':
> videoout_omx.cpp:762:69: error: conditional expression between
> distinct pointer types 'MythRenderEGL*' and 'MythRender*' lacks a cast
>      return VideoOutput::CanVisualise(audio, m_context ? m_context : render);
>                                                                      ^
> videoout_omx.cpp: In member function 'virtual bool
> VideoOutputOMX::SetupVisualisation(AudioPlayer*, MythRender*, const
> QString&)':
> videoout_omx.cpp:770:33: error: conditional expression between
> distinct pointer types 'MythRenderEGL*' and 'MythRender*' lacks a cast
>          m_context ? m_context : render, name);
>                                  ^
> videoout_omx.cpp: In member function 'virtual QStringList
> VideoOutputOMX::GetVisualiserList()':
> videoout_omx.cpp:777:49: error: invalid use of incomplete type 'class
> MythRenderEGL'
>          VideoVisual::GetVisualiserList(m_context->Type()) :
>                                                  ^
> In file included from videoout_omx.cpp:1:0:
> videoout_omx.h:14:7: note: forward declaration of 'class MythRenderEGL'
>  class MythRenderEGL;
>        ^
> Makefile:7130: recipe for target 'videoout_omx.o' failed
> make[4]: *** [videoout_omx.o] Error 1

Hi Thomas,

Two problems:

1. The code that you have is out of date.  I recently fixed a problem
with videoout_omx.cpp when building without OpenGLES2.

2. It appears that the macro USING_OPENGLES is not defined, which
happens if MythTV's configure script doesn't detect Qt's OpenGL support
correctly.  There are several patches to 'configure' in my
fixes-0.27-rpi branch that handle this.  Maybe you are building against
a version of Qt without OpenGLES2 support?

To confirm this, add the following to the top of videoout_omx.cpp:

#ifndef USING_OPENGLES
#error USING_OPENGLES undefined
#endif

This will error if USING_OPENGLES is undefined.  The code should be
built with OpenGLES - it hasn't been tested without.

-- Lawrence Rust