[mythtv] A bunch of bug fixes

Lawrence Rust lvr at softsystem.co.uk
Thu Dec 31 09:37:29 UTC 2015


On Thu, 2015-12-31 at 11:49 +1100, Jean-Yves Avenard wrote:
> On 31 December 2015 at 04:33, Lawrence Rust <lvr at softsystem.co.uk> wrote:
> > Hi,
> >
> > I have around 50 patches to various minor bugs that I've been using for
> > a while now.  They mainly cover the frontend and video playback.  None
> > of them are significant changes so I was hoping to commit them before
> > the 0.28 release.  Before I do so, I wanted to air them to ensure that
> > there are no serious gotchas.  So I've created a new branch:
> > devel/lvr/bugfixes.
> >
> > Please let me know if you spot any problems or have any objections.
> >
> > Thanks.
> >
> 
> Are they the same that went in about 1.5 years ago?

No, with the exception of:

8fdfba5 Fix 0b9470c Fix fileringbuffer locking...

I do believe that you should re-examine this patch.  The logic given in
the commit message is sound and still holds.  I have a several remote
frontends that need this patch to rewind over LiveTV programme
transitions.  In the interim I will hold this patch back.

> Because we had to revert almost every single one of them due to
> various regressions.

At some stage I would like to re-open the discussion on these patches:

0128796 Revert "Player: Enable AVSync to recover quicker after a seek or program change"
d08503e Revert "Player: Finer a/v sync adjustments"
2bdb7cc Revert "Player: Amalgamate and simplify SwitchTo and JumpToProgram"
6634791 Revert "Player: Increase OpenFile timeout to allow playing encrypted isos on a remote FE"

LiveTV playback has been heavily criticised by MythTV users.  The
Jump/Switch/ToProgram functions, together with RingBuffer, are
significant causes of this criticism and we need to address this.
Jitter is also a top priority and A/V sync is a primary cause of this.

I'm not saying that I want to re-introduce the same patches, I accept
that they had problems.  But I do believe that we need to make big
improvements in these areas.

-- Lawrence Rust



More information about the mythtv-dev mailing list