[mythtv] Ticket #12457: livetv not saving volume

[Stuart Auchterlonie]

On 11/12/15 09:29, Lawrence Rust wrote:
> On Thu, 2015-12-10 at 21:25 +0000, Roger Siddons wrote:
>> On 09/12/15 20:45, MythTV wrote:
>>
>>> #12457: livetv not saving volume
>>> -----------------------------------------+-----------------------------
>>>  Reporter:  takuya <8twfr79wnyvqjfkp@…>  |          Owner:  rsiddons
>>>      Type:  Bug Report - General         |         Status:  assigned
>>>  Priority:  minor                        |      Milestone:  unknown
>>> Component:  MythTV - Audio Output        |        Version:  Master Head
>>>  Severity:  medium                       |     Resolution:
>>>  Keywords:  livetv volume save           |  Ticket locked:  0
>>> -----------------------------------------+-----------------------------
>>> Changes (by dekarl):
>>>
>>>  * owner:  jyavenard => rsiddons
>>>  * status:  new => assigned
>>>
>>>
>>> Comment:
>>>
>>>  Roger, seeing your work on #12534 this might be something for you. Feel
>>>  free to unassign.
>>>
>>>  FWIW The volume is reset on audio stream change,too. (manual or automatic,
>>>  e.g. at beginning/end of an ad break) But I'm not finding the ticket for
>>>  that right now.
>>>
>>> --
>>> Ticket URL: <https://code.mythtv.org/trac/ticket/12457#comment:1>
>>> MythTV <http://www.mythtv.org>
>>> MythTV Media Center
>> The LiveTV fix is trivial, but the audio stream change is more tricky.
>>
>> Which leads me to question the rationale behind these changes - "don't
>> save the setting when it changes but try and catch it in a multitude
>> of places later on".
>>
>> There's already been 3 tickets/patches resulting from this. More may
>> surface. And a frontend crash will always revert back to the previous
>> volume.
>>
>> The original issue https://code.mythtv.org/trac/ticket/12144 was about
>> Db optimisation (don't write to Db on every button press).
>>
>> Wouldn't a more simple, robust solution be to just write the volume
>> once after it stops changing, ie. use a timer ? Then we can stop
>> playing whack-a-mole. _______________________________________________
> 
> Hi Roger,
> 
> We're both new here so I thought I'd give you a heads up.
> 
> I've been using a patch to my system for about 2 years now that does
> exactly what you suggested.  It has a hold-off period of 500mS - works a
> treat.  If you are interested you can find it in my patch list -
> http://www.softsystem.co.uk/download/mythtv/mythbuild-CURRENT.zip
> as mythpatches-0.24/mythtv-master/0201-Audio-Offload-dbase-updates...patch
> 
> I'll be creating a some dev branches in the coming weeks with many of
> these tweaks.
> 

Feel free to get that straight into master. Sounds like that's where it
should be.

Cheers
Stuart