[mythtv] [mythtv-commits] Ticket #12157: List all recordings with this title (display group)

[Angela]

>> > A good naming should be decided:
>> > SELECTDISPLAYGROUP
>> > Find Episodes
>> > Find same Episodes
>> > Select same Episodes
>> > Other ideas
>> >
>> > I attached the cumulative patch for the menu, please have a look. I
>> > will make one consolidated patch.
>>
>> Or perhaps "Go to title"?  "Find" sounds to me too much like it would
>> look through the listings (as it seems it's looking through the
>> unknown, versus the known/already-recorded shows).
>Same thought about find.
>Go: Go where, you stay in the same list :)
>
>Maybe better "Show Episodes" or "List Episodes". I think the latter sounds
>for me the best.
>What do you think?
>Angela,
>
>This functionality is really great, thanks!  I can't count the number of times I've wanted exactly that.
>
>I have a couple of comments on the patch.

>1. Near the beginning of PlaybackBox::ShowActionPopup(), a special version of the menu is created if the FileNotFound or ZeroByte conditions hold.  The new menu item should be inserted here as well.
Added it

>2. How about "List Episodes With This Title"?  (It's a bit lengthy, but the same character count as "Allow this episode to re-record".)
As Jean-Yves came with "Find other show like this one", I thought it would be too long. It would look optical very wide in regard to the other items, and having the submenu characters for some other items. The first menu shows narrow, concise options. I prefer concise options, when scrolling through the options it should take little time to read them. Only for unclear dangerous options I like more text. 
I updated the patch with your suggestion. I hope to get some more comments, so everybody is happy. As also the translations depend on it. (This is one of the reasons I don't like human interface programming).
Also how the ACTION should be called: SELECTDISPLAYGROUP or LISTEPISODES, LISTEPISODESSAMETITLE

>3. Watch out for tab characters, use "if (cond)" instead of "if(cond)", etc. :)
And braces on the next line. I configured notepad++ again to fix the spaces for cpp.

>4. I'm a big fan of always having actions available as menu items, and not just keybindings, for the poor remote control users, so it's great that you did both.