[mythtv] [mythtv-commits] Ticket #12157: List all recordings with this title (display group)

[Jim Stichnoth]

On Fri, May 30, 2014 at 12:05 PM, Angela <angela.schmid at wolke7.net> wrote:

> > > "Find other show like this one" is a little too long, "Find Episodes"
> > > would better fit in the rather narrow menu.
> > >
> > > A good naming should be decided:
> > > SELECTDISPLAYGROUP
> > > Find Episodes
> > > Find same Episodes
> > > Select same Episodes
> > > Other ideas
> > >
> > > I attached the cumulative patch for the menu, please have a look. I
> > > will make one consolidated patch.
> >
> > Or perhaps "Go to title"?  "Find" sounds to me too much like it would
> > look through the listings (as it seems it's looking through the
> > unknown, versus the known/already-recorded shows).
>
> Same thought about find.
> Go: Go where, you stay in the same list :)
>
> Maybe better "Show Episodes" or "List Episodes". I think the latter sounds
> for me the best.
> What do you think?
>
> Angela,

This functionality is really great, thanks!  I can't count the number of
times I've wanted exactly that.

I have a couple of comments on the patch.

1. Near the beginning of PlaybackBox::ShowActionPopup(), a special version
of the menu is created if the FileNotFound or ZeroByte conditions hold.
 The new menu item should be inserted here as well.

2. How about "List Episodes With This Title"?  (It's a bit lengthy, but the
same character count as "Allow this episode to re-record".)

3. Watch out for tab characters, use "if (cond)" instead of "if(cond)",
etc. :)

4. I'm a big fan of always having actions available as menu items, and not
just keybindings, for the poor remote control users, so it's great that you
did both.

Thanks again!

Jim
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mythtv.org/pipermail/mythtv-dev/attachments/20140530/ebbfd537/attachment.html>