[mythtv] [mythtv-commits] Ticket #12157: List all recordings with this title (display group)

[Michael T. Dean]

On 05/29/2014 03:14 PM, Angela wrote:
> Hello Mike,
> I adapted the patch according your suggestions.

Looks great.  Thanks again for the nice features and the quick response 
to the requested changes.

See my reply to JYA if you want to do the extra work to add a default 
key binding.  IMHO, it's completely optional and above and beyond the 
call of duty (aka more work/code than it's worth), but if popular vote 
(or developer vote) says you must, it describes the 2 approaches that 
can be taken.

> PREV/NEXTVIEW don't have ACTION_, using "NEXTVIEW", like everywhere in the code.
> Works fine, can you please have a look.

Yeah, Mark K started adding defines for the actions when he did some 
work on the frontend web control stuff (IIRC), but didn't finish.  They 
would go in mythtv/libs/libmythui/mythuiactions.h , but rather than add 
them in for this patch, it would probably be better to wait until this 
patch goes in, and then someone can add them and update all uses of 
NEXTVIEW/PREVVIEW to use the macros in a no-functionality-change patch.

> I had a key-involving patch for Netvision: https://code.mythtv.org/trac/ticket/12071
> Which I will also adapt based on your suggestions.

Great.  Thanks.

Mike