[mythtv] [mythtv-commits] Ticket #12157: List all recordings with this title (display group)

Michael T. Dean mtdean at thirdcontact.com
Thu May 29 16:40:15 UTC 2014


On 05/28/2014 08:43 PM, MythTV wrote:
> #12157: List all recordings with this title (display group)
> ------------------------------------+--------------------------------------
>       Reporter:  angela.schmid@…     |      Owner:
>           Type:  Patch - Feature     |     Status:  new
>       Priority:  minor               |  Milestone:  unknown
>      Component:  MythTV - Recording  |    Version:  0.27.1
>       Severity:  medium              |   Keywords:  display group recordings
> Ticket locked:  0                   |
> ------------------------------------+--------------------------------------
>   Pressing the "+" key for a selected recording in the view recordings
>   list, selects the display group based on the recordings title, showing
>   all recordings with the same title.
>
>   The HOME and END keys scroll through the display groups, focus remains
>   in the recordings list or in the group list (then behaving the same as
>   UP/DOWN).

Angela,

This is a nice patch--and a feature I've often thought about adding.  My 
only concern is that generally when we add a new action to MythTV, we 
leave it without any default binding unless it's a critical action 
because otherwise any user who has mapped the + key in the TV Frontend 
or Global contexts will have a key conflict that they're unlikely to 
figure out, and that will cause confusing behavior that will be reported 
as bugs.  :(

It does mean that users who want the functionality will have to map a 
key to the new action themselves, but it prevents problems/bugs from 
being added sinply due to an upgrade.  We know that's not ideal, but 
when I get a chance to make time to finish my key bindings themes patch, 
users will be able to create and share key bindings themes--which could 
map any of the new actions as desired.

Also, when adding new actions, you should create the defines for those 
actions , so please add SELECTDISPLAYGROUP to 
mythtv/libs/libmythtv/tv_actions.h and use the define in your patch.  
I'd also recommend removing the default binding for the new action.  
Doing these 2 things would make TV Frontend/SELECTDISPLAYGROUP perfect.

And the only problem with the scroll-through-display-groups portion is 
its reuse of existing, not-yet-used-in-the-specific-subcontext, but 
completely-unrelated-to-the-desired-effect, actions DAYRIGHT and 
DAYLEFT, effectively overloading the existing actions such that the 
DAYRIGHT/LEFT and scroll-through-display-groups effects can't be bound 
differently (to different keys and/or distinctly--allowing use of both 
in the playbackbox***).  However, this problem is everywhere throughout 
MythTV and we don't yet have a good way to deal with it, so we could fix 
that when we fix the rest of the action overloads.  Oh, and IIRC, we 
used to have the exact feature (possibly with the same overloaded 
actions?) before the MythUI conversion, so having the feature back would 
be a good thing.

That said, it seems you chose DAYRIGHT/LEFT for the End/Home keys to 
which they were bound.  There already exist bindings Global/NEXTVIEW and 
Global/PREVVIEW that are also mapped to End/Home keys.  TTBOMK, even 
though we do a TranslateKeyPress() for "TV Frontend" context, it should 
map the keys to the NEXT/PREVVIEW global actions, too.  So, if you 
change the DAYRIGHT/LEFT actions to NEXT/PREVVIEW, does it work the 
same?  If so, I'd recommend using those actions as they're more sensibly 
named for the behavior and would not result in any action overloading.

Thanks,
Mike

*** One could imagine, for example, some Global/HOME and Global/END 
actions being used as a means of jumping to the top or bottom of a list 
anywhere in MythTV.  If these actions were bound by default to the 
Home/End keys, the TV Frontend/DAYRIGHT and TV Frontend/DAYLEFT default 
bindings to End/Home would now conflict within the TV Frontend context 
and make it impossible to jump to the top/bottom of the list in the 
playbackbox.  Or, one could imagine functionality in playbackbox such 
that TV Frontend/DAYRIGHT and TV Frontend/DAYLEFT were used--as their 
names would imply--to skip down/up the list of recordings to those 
recorded the next/previous day as compared to the recording that was 
highlighted when the button was pressed.

But, since we don't yet have a way to distinguish between subcontexts 
(such that DAYLEFT/DAYRIGHT are mapped to End/Home in the guide and the 
new actions NEXTGROUP/PREVGROUP are mapped to End/Home in the 
playbackbox--since both the guide and the playbackbox are in the TV 
Frontend context), and since we can't allow multiple actions in a single 
context (TV Frontend) to be mapped to the same key (i.e. map both 
DAYLEFT and NEXTGROUP, we have been overloading actions like this for years.


More information about the mythtv-dev mailing list