[mythtv] [mythtv-commits] mythtv branch master updated by paulh. v0.28-pre-530-ge02bbc5

[Paul Harrison]

On 19/11/13 19:19, Jim Stichnoth wrote:
> On Sun, Nov 17, 2013 at 6:06 AM, Git Repo Owner <noreply at mythtv.org 
> <mailto:noreply at mythtv.org>> wrote:
>
>     The branch, master has been updated on the
>     mythtv repository by gitolite user paulh.
>            via  e02bbc5ebda1ab8cf8616829a03f96a4e4918e03 (commit)
>           from  0e8e2e3527ad26d34edb5899300cef0d9e863bce (commit)
>
>     Those revisions listed above that are new to this repository have
>     not appeared on any other notification email; so we list those
>     revisions in full, below.
>
>     - Log
>     -----------------------------------------------------------------
>     commit e02bbc5ebda1ab8cf8616829a03f96a4e4918e03
>     Author:    Paul Harrison <pharrison at mythtv.org
>     <mailto:pharrison at mythtv.org>> at Sun, 17 Nov 2013 14:05:06 +0000
>     Committer: Paul Harrison <pharrison at mythtv.org
>     <mailto:pharrison at mythtv.org>> at Sun, 17 Nov 2013 14:05:06 +0000
>     URL:
>     http://code.mythtv.org/cgit/mythtv/commit/?id=e02bbc5ebda1ab8cf8616829a03f96a4e4918e03
>
>     MythMusic: fix compilation for users of taglib < 1.8
>     Seems you need tablib >= 1.8 to remove Picture blocks from xiph
>     comments
>     but the minimum we currently support is 1.6 so since this is a
>     rarely used
>     feature just disable it on taglib < 1.8 for now.
>
>     Refs #11947.
>
>
>
>     -----------------------------------------------------------------------
>
>     Summary of changes:
>      mythtv/libs/libmythmetadata/metaioflacvorbis.cpp |   15
>     ++++++++++++++-
>      1 files changed, 14 insertions(+), 1 deletions(-)
>
> FWIW, this commit doesn't do enough for taglib 1.6.  See the build 
> errors at http://pastebin.com/BcA6yNA5 .
>
> Jim
>
>

Ah sorry about that once I got the buildbots happy I didn't look any 
further than that.

We should probably make 1.7 the minimum version in that case or just be 
a devil and jump to 1.8 now? Like Stuart said by the time we release 
0.28 even dinosaur distros like centos will be using 0.28.

Paul H.