[mythtv] Coverity issues 700810 700325 suggested resolution

Gary Buhrmaster gary.buhrmaster at gmail.com
Wed Jun 26 18:05:02 UTC 2013

I would suggest that Coverity issues 700810 and 700325
be marked as "acknowledged"/"accepted".  Both are
in upstream code.  The first (uninitialized buffer2 in ctor)
is correct, but the code only uses it after appropriate
initialization.  The second (cannot reach express) is
absolutely true.  It is in the lirc_client code as
distributed.  While that entire code fragment should
probably be rewritten (by lirc), it is not a MythTV issue.

Thanks for your consideration.


Coverity refs:

Uninitialized pointer field: Non-static class member
  "buffer2" is not initialized in this constructor nor in
  any functions that it calls.
  (700810) /mythtv/libs/libmythbase/unzip.cpp:497

Logically dead code: Execution cannot reach this expression
  ""lircrcd"" inside statement "sha_bang2 = ((sha_bang != N..."
 (700325) /mythtv/libs/libmythui/lirc_client.c:917

More information about the mythtv-dev mailing list