[mythtv] 0.27 code cleanliness
Stuart Morgan
stuart at tase.co.uk
Tue Oct 9 08:56:00 UTC 2012
On Monday 08 Oct 2012 18:45:55 Gary Buhrmaster wrote:
> Devs,
>
> It is my understand that one of the goals for 0.27 is general
> code "cleanliness", with the result that there are fewer warnings
> (with -Wall) so that any new ones might suggest something to
> look further at (right now the posture child is all the overloaded
> virtual function hidden warnings).
> As part of general code cleanup, I can contribute patches to
> replace the var: syntax with .var syntax. If I do so, is it likely
> that such patches will be accepted.
We will generally accept patches against code written by MythTV developers. I
stress that last part because the example you chose, RTjpegN.cpp, is in fact
third party code that we've included into our code base, we normally don't do
code formatting and correctness fixes for those because it would make re-
syncing them harder. RTjpeg may even be dropped in favour of more modern
codecs.
At some future date we fully intend moving all imported files/classes into
subfolders labelled 'external' to make it clear what is and what isn't our
code. This will also make them easier to ignore in static analysis scans etc.
If you do supply patches, please split them up into bite-size chunks,
preferably not touching multiple libs, or too many files at once. This will
make them easier to review and easier to apply, especially if one of the files
changes before we can get to that point.
--
Stuart Morgan
MythTV
More information about the mythtv-dev
mailing list