[mythtv] [mythtv-commits] Ticket #10428: mythbackend logs RingBuf-messages every few seconds while playing LiveTV

[Lawrence Rust]

On Tue, 2012-07-24 at 20:15 -0400, Daniel Thor Kristjansson wrote:
> On 07/24/2012 04:28 PM, Lawrence Rust wrote:
> > On Tue, 2012-07-24 at 18:33 +0000, MythTV wrote:
> >> #10428: mythbackend logs RingBuf-messages every few seconds while playing LiveTV
> >> Comment (by Daniel Thor Kristjansson <danielk@…>):
> >>   In [changeset:483e06f6b8a9066f66cef3fcf0a5f844519f51f9/mythtv]:
> >>   The estimated bit rate is in kilobits not bits...
> >
> > Hooray, at last reason prevails.  This was submitted as a bug and patch
> > in ticket #9824 over 14 months ago.  Mark Kendall wriggled and protested
> > and refused to see this.
> >
> > Can this be backported to 0.2[45] so that listeners to DVB-S radio can
> > benefit?
> 
> It was pretty obviously broken. If this doesn't cause any regressions
> I am open to backporting it. I just noticed this when I was looking at
> #10658 which should make the ringbuffer a bit more responsive; although
> that is still a work in progress.

Ticket #9824 also included a change to RingBuffer::WaitForAvail which
effectively implements what is proposed in #10658.  I have been using
this patch for over 14 months now with good effect on radio, SD and HDTV
streams played both locally and over 100Mbps Ethernet, 56Mbps WiFi and
200Mbps PowerLAN (20Mbs in practice) links.  I haven't seen any problems
with ffmpeg/avformatdecoder.

> I just looked at #9824, and Mark's defense there are a lot of things
> in that patch and I'm sure if you had submitted a separate patch for
> just this he would have applied that pretty quickly.

I see what Mark was getting at - he wanted a series of small patches
that he could easier understand.  But some things don't work that way.
To get low bitrate DVB-S radio working needs all of those changes.
Applying a number of the changes on their own would have been
detrimental so that's why I posted the changes 'en masse'

-- 
Lawrence