[mythtv] [mythtv-commits] Ticket #9824: [PATCH] MythPlayer: Fix playback of dvb-s radio channels

[Mark Kendall]

On 13 October 2011 18:54,  <noreply at mythtv.org> wrote:
>  >As a general observation (and this applies to various patches you've
>  submitted, not just these), your patches are difficult to review because
>  they contain various unnecessary and largely cosmetic changes that obscure
>  what you are really trying to achieve. For example, converting locks to
>  use QMutexLocker is fine but put them in a different patch.
>
>  I don't accept that.  All the changes contained in these 2 patches are
>  necessary with the exception of the additional log output which is
>  'cosmetic'.  Your example, mutex lockers, are required here to facilitate
>  returns without explicitly calling unlock.  They improve readability and
>  enable additional return points.

Lawrence

I stand by what I wrote. Those locking changes are entirely
superfluous and simply represent a different coding style.

It was however just a suggestion. You can chose to ignore it but
everyone is short of time and contributors making it easier for
developers to review and apply patches is a win/win.

I can think of at least one project where that patch would have been
dismissed out of hand.

regards

Mark