[mythtv] [mythtv-commits] Ticket #9442: configure libxml2 with pkg-config
Michael T. Dean
mtdean at thirdcontact.com
Tue Jan 4 22:49:05 UTC 2011
On 01/04/2011 04:14 PM, MythTV wrote:
> #9442: configure libxml2 with pkg-config
>
> Comment (by Lawrence Rust<lvr@…>):
>
> Just found a minor problem. The output of pkg-config has a trailing space
> which is passed onto gcc as an include path and so gcc fails to find the
> xml headers. Need to massage the output to remove the trailing space:
>
> + libxml2_path=`pkg-config --cflags-only-I libxml-2.0|sed -n
> "s/-I\([^ ]*\) *$/\1/p"`
Any chance you could send a patch to upstream libxml to remove
the--obviously, as you've found--incorrect end-of-line space at the end
of the "Cflags: -I${includedir}/libxml2 " line (as well as the
Libs.private line, while you're at it--just for prettiness) in
libxml-2.0.pc (no idea where that lives in Windows). Having a hack in
our code to deal with a bug in the libxml2 make/install tools, where the
hack is only required for Windows, just sounds like a mess when it
should be possible to fix upstream.
If having the script patch, or packaging a patched version and hosting
it on our Google Code prereqs download site, or making sure the script
gets the upstream version with the fix, or even having our script
actually fix the already-installed-by-the-broken-libxml2-installer
libxml-2.0.pc file isn't an option, then if nothing else, it will allow
us to remove the hack in the future.
Thanks,
Mike
More information about the mythtv-dev
mailing list