[mythtv] confusing conditional

Chris Pinkham cpinkham at bc2va.org
Tue Feb 15 22:39:33 UTC 2011


* On Thu Feb 10, 2011 at 10:27:39AM -0800, Erik Hovland wrote:
> Anyone have any idea how this condition works. This is in
> mythtv/libs/libmythtv/cc608decoder.cpp, in the member function
> CC608Decoder::XDSDecode.
> 1096     // Supports non-interleaved XDS packet continuation by ignoring cont.
> 1097     if ((b1 < 0x0f) && (b1 > 0x0f))
> 1098         return;
> 
> My feeble understanding of math says that b1 cannot
> be both less then 0xf and greater then 0xf at the same time.

Ditto.  You'd might have to ask Daniel specifically since that's his
line of code:

https://github.com/MythTV/mythtv/commit/7af9c6a8

Perhaps one of those is supposed to be b2, but I don't know that
code at all so I'm only speculating.

--
Chris


More information about the mythtv-dev mailing list