[mythtv] [mythtv-commits] mythtv/master commit: d3644e038 by Robert McNamara (rmcnamara)

Robert McNamara robert.mcnamara at gmail.com
Fri Apr 22 17:21:35 UTC 2011

On Fri, Apr 22, 2011 at 10:12 AM, Rob Smith <kormoc at gmail.com> wrote:

> On Fri, Apr 22, 2011 at 9:38 AM, David Blain <mythtv at theblains.net> wrote:
> > GetVideoById and GetVideoByFilename share a lot of functionality...
> wouldn't
> > it make sense to create a private/protected function that both can share?
> >
> > David.
> My typical work flow would be to have GetVideoByFilename just get the
> id and call GetVideoById, no need for hidden functionality and it
> gives a single code path.
There's nothing hidden in this case--  both by Filename and byID return a
full metadata record-- they both exist for convenience (I added both because
the underlying metadata classes expose both), there's no need to perform two
steps when it comes to this.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.mythtv.org/pipermail/mythtv-dev/attachments/20110422/cd45b091/attachment.html 

More information about the mythtv-dev mailing list