[mythtv] [mythtv-commits] mythtv/master commit: 2b3de68dc by Mark Kendall (mark-kendall)

Jean-Yves Avenard jyavenard at gmail.com
Sun Apr 17 23:35:31 UTC 2011

On 18 April 2011 05:56, Michael T. Dean <mtdean at thirdcontact.com> wrote:

> Saying to revert the commit is saying it has absolutely no value and is
> completely wrong and that MythTV was--and will be--better off without
> any part of the changes.  Having seen Mark's work in general, I find
> that hard to believe--hard enough to believe that I would expect someone
> who understands exactly what's wrong with the current code would be able

There is a problem though if the previous code required those changes
in the loop, then the new code can't work.

avcodec_decode_audio3 will decode only one audio frame at a time ;
while "pkt" may contain more than one frame.

What the new code will do as such, is always decode the same one
should there be more than one audio frame in pkt.

the pkt.data and pkt.len should be modified in place of the old ptr
and len ; though you can't directly modify pkt because it would lead
to leaks when freeing the audio packet.

> However, since cleaning up compiler warnings has value, I would
> expect that it's possible to fix the code to work without compiler
> warnings

It would have been an FFmpeg warning that avcodec_decode_audio is now obsolete.

Maybe we should have let the person responsible for mythmusic handle
it and instead submit changes for his review first. Maybe this was
done, I apologise for any incorrect assumptions I could have made.


More information about the mythtv-dev mailing list