[mythtv] [mythtv-commits] Ticket #8999: [PATCH i18n] Remove empty source string from NB MythMusic translation

Nick Morrott knowledgejunkie at gmail.com
Fri Sep 24 17:29:43 UTC 2010


On 24 September 2010 18:02, MythTV <mythtv at cvs.mythtv.org> wrote:
> #8999: [PATCH i18n] Remove empty source string from NB MythMusic translation
> -----------------------------------------------------------------+----------
>  Reporter:  Nick Morrott <knowledgejunkie <at> gmail <dot> com>  |           Owner:  knight
>     Type:  patch                                                |          Status:  closed
>  Priority:  minor                                                |       Milestone:  unknown
> Component:  Translations                                         |         Version:  Trunk Head
>  Severity:  medium                                               |      Resolution:  fixed
>  Keywords:                                                       |   Ticket locked:  0
> -----------------------------------------------------------------+----------
>
> Comment (by anonymous):
>
>  Thanks Nick for your patch!
>
>  Since these files are externally maintained it's possible that this might
>  get reintroduced in this or other translations files, let's just hope it
>  doesn't...

Having spoken to Kenni last week about these empty strings off-list
(they were affecting the stats generation), the issue is that lupdate
doesn't handle them correctly - whether the "correct" handling would
be for lupdate to delete them I can't say - and includes them as valid
translations, only for lrelease to not translate them. This results in
differences in the number of translations reported by the two tools.
Once removed from a .ts file they shouldn't reappear unless a
translator is using an old checkout and submits a diff which adds them
back.

Before sending the patch I grepped the current source and this was the
only empty string found, after the efforts last week to locate and
remove them all, and I'll try to keep an eye on things as we near the
release.

>  PS: I did not regerate the qm files since they were not affected.

Perfect - the patch was only removing a string that lupdate and
lrelease can't handle.

Cheers,
Nick

-- 
Nick Morrott

MythTV Official wiki: http://mythtv.org/wiki/
MythTV users list archive: http://www.gossamer-threads.com/lists/mythtv/users

"An investment in knowledge always pays the best interest." - Benjamin Franklin


More information about the mythtv-dev mailing list